[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/tboot: adjust Kconfig default
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Date: Thu, 3 Mar 2022 06:50:05 -0500
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1646308250; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=u1ipkWFozDh9LOJ4TpEVmQcDvF1/FctYY95E7PwvFY4=; b=ek7FS/yWcs3EnXpr1zCmxp2Q2+9eE4aTS4Tuq65BcyjqbXsvY7t8DMD1oS/7Ydl9pAy6KQzHHBvY5nTkvdjrur1oEPlrZz18oRXdUF0Y7DEUL9lgtveKWi4wQH7QjxlVDNZoEBsF2hTm1H+/9HwAfohKox2A0sTWQsJh0LskCBI=
- Arc-seal: i=1; a=rsa-sha256; t=1646308250; cv=none; d=zohomail.com; s=zohoarc; b=MeeCbcKzjaM0FR3yn8mr4Nut+EeM5sEQeZ7pQdu5HDNltHWWBQ6MduG9VGc/WJL4fopVYnHJd64P7fr39hq23K3/cnVjm6T54LghbVlJgmY2hScNUqZYtqEYlo1OUXad7o/Fd9fDFqU9IE7MW/SkeRa4xzv2XAoCIwhsJtB7uL0=
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Lukasz Hawrylko <lukasz.hawrylko@xxxxxxxxxxxxxxx>, Mateusz Mówka <mateusz.mowka@xxxxxxxxx>
- Delivery-date: Thu, 03 Mar 2022 11:51:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 3/3/22 04:49, Jan Beulich wrote:
We shouldn't include unsupported code by default, with not even a means
for its building to be disabled. Convert the dependency from merely
affecting the prompt's visibility to a real one.
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
---
We could of course go further and make the default also account for
DEBUG, as is done elsewhere.
As in you would like to adjust the default based on whether DEBUG is on
or not? I guess my question is what motivation is there to adjust this
selection if DEBUG is enabled or disabled?
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -193,14 +193,15 @@ config HVM_FEP
If unsure, say N.
config TBOOT
- bool "Xen tboot support (UNSUPPORTED)" if UNSUPPORTED
- default y if !PV_SHIM_EXCLUSIVE
+ bool "Xen tboot support (UNSUPPORTED)"
+ depends on UNSUPPORTED
+ default !PV_SHIM_EXCLUSIVE
select CRYPTO
---help---
Allows support for Trusted Boot using the Intel(R) Trusted Execution
Technology (TXT)
- If unsure, say Y.
+ If unsure, stay with the default.
choice
prompt "Alignment of Xen image"
Outside of the debug question, I think the proposed change is good.
Reviewed-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxx>
|
