[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/tboot: adjust Kconfig default


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Date: Thu, 3 Mar 2022 06:54:47 -0500
  • Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1646308529; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=bVxTogiblHHgRMkjL1zPZ9Zsmo3Slz+NqJrINZH0Htk=; b=d5V0zzAhF5CVq/SOxesbFsla1myUXTbShtxZsLpPq7TJI18gQlUp1e3GbVNkkuuWYABhnfpKai097FSghOb+QYM0SOGZsvFCxih48p8mlGIAekCrytZy2cYd12zGIoNfO3J7G1eiIQQfjt5lIxdcim59AC97eG2S3IvQfrUXm5o=
  • Arc-seal: i=1; a=rsa-sha256; t=1646308529; cv=none; d=zohomail.com; s=zohoarc; b=KvTp8J00kbQhYuQvGlE1Z/ZfM3uLZ6EYX3PsRr1XNWWGOF8X2HKMsF30tOZD+EcMMJAIEH3NVub+j1vMrYiLJtF2O2u3E9bu1F0lYXKjZCZZf/Q8X+hpMoyG/dxctYlXAg9VJIF7wEwqJIDKy5IOZI/p/SxXWUG1anBNJ9OvF4A=
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Mateusz Mówka <mateusz.mowka@xxxxxxxxx>, Łukasz Hawryłko <lukasz@xxxxxxxxxxx>
  • Delivery-date: Thu, 03 Mar 2022 11:55:42 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Jan,

FYI, I just noticed that Lukasz old intel email was used for this patch. I assume your tree just hasn't picked up the patch with his new email address. Copying him now so he can see your patch.

v/r,
dps

On 3/3/22 06:50, Daniel P. Smith wrote:
On 3/3/22 04:49, Jan Beulich wrote:
We shouldn't include unsupported code by default, with not even a means
for its building to be disabled. Convert the dependency from merely
affecting the prompt's visibility to a real one.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
---
We could of course go further and make the default also account for
DEBUG, as is done elsewhere.

As in you would like to adjust the default based on whether DEBUG is on or not? I guess my question is what motivation is there to adjust this selection if DEBUG is enabled or disabled?

--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -193,14 +193,15 @@ config HVM_FEP
        If unsure, say N.
  config TBOOT
-    bool "Xen tboot support (UNSUPPORTED)" if UNSUPPORTED
-    default y if !PV_SHIM_EXCLUSIVE
+    bool "Xen tboot support (UNSUPPORTED)"
+    depends on UNSUPPORTED
+    default !PV_SHIM_EXCLUSIVE
      select CRYPTO
      ---help---
        Allows support for Trusted Boot using the Intel(R) Trusted Execution
        Technology (TXT)
-      If unsure, say Y.
+      If unsure, stay with the default.
  choice
      prompt "Alignment of Xen image"


Outside of the debug question, I think the proposed change is good.

Reviewed-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.