[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/tboot: adjust Kconfig default


  • To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 3 Mar 2022 13:24:03 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YJoEDkTZkuyQsVzjxbobMx52E/VrmcDk4QS4gEuUAvg=; b=hLe5dcoRl959UehKLTzNuKfx/zjN5zZbGCdiaPT5pKpWZ1DmyDJCzTt+0LdvDkFFp/Yd2kaBhFunJUxYw0Nusr1hioNH4ILLXMDagCneBOdYU3M+Y8smWFza9zMP/Uc6jbVIdHUbtBHwek+nATkSF10iVW7/fmBc/vCG1c68wPoouKSH7KxycwK2hjJV+GhGUn0Ux+8gT/xK8MYonoMK4KnYL7dTUZsvx2ifdOJgWg38kYf0sFy+iVydJDlTE7HsM9+Gm2ctudMOQWyJD4uTBKsGg6h04uqerQKVa9exz/zBLD0RhVpA+tE7yJM2vBe5AUv14sKlCV6NWkElRhYpIg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fyGeIaGUOvSRcyMQVyFMNJ8Lz+KtuT9IoD4Eh5EihNFlF+dfhzlYG/LZPTd3Zu73iuvQcl3EPGPB6SS9mI1d9SSPPvijL15P9MZgK1A9HioUnZyTK0Cc2pKdRZ8nAabG+78WZGLY46U6P7JrPxmtf4Hus6vOrEOAjIdp7GUojOs8mHlTBgYPcYaI8+NT9GkFnqlySY68V5L9oN9C2PeaL2966BEBTL+VFAnGT/FVZ1HVX5yXs4spVvWgjQmKo94V72A3pNvkFZX7kvvG7SUe1GUf1zqqs3la4zgQatRL3j9m7gsxI1atfzK9TFk26HfXFKggbO9Mgc3wvEh7TTCsFA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Mateusz Mówka <mateusz.mowka@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Lukasz Hawrylko <lukasz@xxxxxxxxxxx>
  • Delivery-date: Thu, 03 Mar 2022 12:24:19 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 03.03.2022 13:16, Daniel P. Smith wrote:
> 
> On 3/3/22 07:03, Jan Beulich wrote:
>> On 03.03.2022 12:50, Daniel P. Smith wrote:
>>> On 3/3/22 04:49, Jan Beulich wrote:
>>>> We shouldn't include unsupported code by default, with not even a means
>>>> for its building to be disabled. Convert the dependency from merely
>>>> affecting the prompt's visibility to a real one.
>>>>
>>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>>> ---
>>>> We could of course go further and make the default also account for
>>>> DEBUG, as is done elsewhere.
>>>
>>> As in you would like to adjust the default based on whether DEBUG is on
>>> or not? I guess my question is what motivation is there to adjust this
>>> selection if DEBUG is enabled or disabled?
>>
>> This is to have functionality enabled unless overridden in debug builds.
> 
> Maybe I am misunderstanding you. If I am wanting to debug either TXT or 
> a configuration with TXT on and I adjust my config to turn on debug, 
> then I would have to go turn TXT back on. Is that correct? If that is 
> the correct understanding, honestly that concerns me because if that is 
> being done for other config options, it would create the situation where 
> turning on debug to track down an issue would result in a different 
> configuration than the one I was experiencing the issue.

In the scenario that you describe (aiui), the default setting wouldn't
make a difference: If you alter an existing .config by turning on DEBUG,
the .config's existing TBOOT setting wouldn't change. Defaults matter
only for items which have no values recorded yet. Plus - I'm suggesting
to turn the option _on_ by default when DEBUG=y, not off.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.