[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v9 24/30] build: grab common EFI source files in arch specific dir
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 3 Mar 2022 17:54:44 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uy537r82tTzX1+NV/ybruwDcslf1cl8YysuhP0X/usI=; b=hSJZbMmCpbzUtAVaQA2roUVo1g8IlwXiHWrXQg6CXZT7ggFDYiT794lq8Zr5/1mOyehr3yxPxdw7kfK69SU96rnblqTgYgzi+yqVr1ObtRE18A/XCSMCEm1FYM55A8H3Oa874LVonF+SbjUcTw+AeZLqC6hbK84dYOmc9ySNVlMhUHV9oUfZmuRt4U5U5djOnyckTv+XAc2nwtFtc1Ja2nneme4UyS36cCWnaCR123J55cnuW1CE7xGy0cDs3p0sAbEGvxO0P363XOykGCKgd2LT028zwK+Qihi0bVkQeBryX+9gTlDP0YukqiOhZ1xT9UhKJXh6aY5HoCaNq5rEwg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C/rh9PXHh2l2MH9UOnHeLPzXA09WEfh+rWeKKY+aQPFZV5S04jhsOPtaA67635spVWjV+vI9Ix0GC5qmgkS+weciQcfpAhA8wsK0vEPzrRcRjUi0N6s/GBPts6V1KUN+Qr1SbY8m6wG/WyB2ulCp+1qYd+Pm9Z/leBDZ4mWlslmTQ0dv3O9+uI/ck5aeLTg+dnleAzosId1CXhs5nZ8mSPJKGbbCh7kLFXM1BnIuh9diB3A5FaSeyk79rCDkXTekdxvuLNU/pp3qYq88t4kq35MTVXB7pcya/+j5uV5orSOdesCC3hY9CZcwUAfPYCKeUb777Ez/5KPpwznKFC7FOg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 03 Mar 2022 16:54:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 03.03.2022 17:50, Anthony PERARD wrote:
> On Thu, Mar 03, 2022 at 05:01:07PM +0100, Jan Beulich wrote:
>> On 03.03.2022 16:41, Anthony PERARD wrote:
>>> On Thu, Mar 03, 2022 at 11:37:08AM +0100, Jan Beulich wrote:
>>>> On 25.01.2022 12:00, Anthony PERARD wrote:
>>>>> +# Part of the command line transforms $(obj) in to a relative reverted
>>>>> path.
>>>>> +# e.g.: It transforms "dir/foo/bar" into successively
>>>>> +# "dir foo bar", ".. .. ..", "../../.."
>>>>> +$(obj)/%.c: $(srctree)/common/efi/%.c FORCE
>>>>> + $(Q)ln -nfs $(subst $(space),/,$(patsubst %,..,$(subst /,
>>>>> ,$(obj))))/common/efi/$(<F) $@
>>>>
>>>> What is the "reverted" about in the comment? Also (nit) I think you want
>>>> s/in to/into/.
>>>
>>> I've tried to described in the single word that the result is a relative
>>> path that goes in the opposite direction to the original relative path.
>>> Instead of going down, it goes up the hierarchy of directories.
>>> Maybe "reversed" would be better? Do you have other suggestion?
>>
>> I'd simply omit the word. In case you're fine with that, I'd be happy
>> to adjust while committing.
>
> I think that would sound kind of strange. $(obj) is already a relative
> path. It would probably be better to just drop the end of the sentence
> in that case. With the example showing what is happening, that would
> probably be enough. The sentence would then be:
>
> # Part of the command line transforms $(obj).
> # e.g.: It transforms "dir/foo/bar" into successively
> # "dir foo bar", ".. .. ..", "../../.."
Fine with me. Then:
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
