[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC
- To: Jane Malalane <Jane.Malalane@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 8 Mar 2022 17:02:31 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hP5MYYqJ19dAI1jFhfiLZssLcY4DL4Hh0KobK7hBq8g=; b=gFS/GVw1QQhc9YsxnuL06v6j3FbQHtHdMOjwMkWqFRPXwB32ua/onbGILdgXj9AtehW5qwmAMpktvCJ6EAQrArH1XxLetoIJDWQvPcQegzshG9z/KE7rftmncEb6IdokbYkMBmiguLt+Q1PTU3eSIkMZrQjlH9zvio3cJgNh8hlpc3nFbUPlWlPMUYiRzgFcS5nBk93a3Xi3axvme04NsQNnHeGKJrxkgewT4v2eZs6ZvOHHgHfTpvByhZy9dPcyoSiqXJaK0RvXuWN9sSx+yTYqHsSqEQTAtbbPmzMwp6xyxm5hIr1bBxSrCmskxuh34iEGOKuts3IWP5VJ39WDeA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OdaCB8X06GX3Zce0G+a6aRx1Qghhfk9JgmM76OxDmhkAohEo5J04OW1xtOc7yY3nyeJXCylDZxwDgTWNaIndsQ8LwIks0fI4NphEVXMvFYVFcPRu0IHIjnYuPQB5AYW9xn0hyJhIxFNCLaarjTqoa+C/KRGKHRvs1NzwkyspXGGJWgqMtDwkZknXt8Zp+QJEk26Ifqphtx3asXNMNHkZSh6dHBgCfXsbp5i3lKtgbpMBsJDWXYSbv2G5tGc9Ess35Q97nX1kMZNUz1rEZNRNuyzjBu1RUVH1OQ4eFbVLURxSDHA3qfWvWEObuc3qFDg8wvJE8OLTkUAZSJnD4eSJ6Q==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 08 Mar 2022 16:02:44 +0000
- Ironport-data: A9a23:z3UFQawko7y3pkUp2656t+fLxirEfRIJ4+MujC+fZmUNrF6WrkUPx jYXUDqDParbZ2uhfdt2YISzpEoDv8fTy9RkQQpppCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NYz2YjhWWthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ Npl6aS5ey01ZLH3veUdXjhZHyJ6PKZq5+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2J0RRKaCP ZFxhTxHPSb+fQEIFg8rV8gdmfuPhHrRIhtitwfAzUYwyzeKl1EguFT3C/LOYcCDT8hRmkeep 0rF8n7/DxVcM8aQoRKH73ati+nnjS79HoUIG9WQyPluh1GCw30JPzcfX1C7vPqRh1a3XpRUL El80iYns6Ua7kGgSdj5GRqirxasoRo0S9dWVeog52ml2qfSpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWXQ3+A8rafrRupJDMYa2QFYEcsTwQf5ML4iJoulR+JRdFmeJNZlfWsR2u2m WrT6nFj2fND1qbnyplX43ibuzuejISTUjUQ5wXaf2Op7Qd4b6K6MtnABUfg0d5MK4OQT1+kt XcCmtSD4O1mMaxhhBBhU81WQuj3uq/t3Cn0xAc2QsJ/r2jFF2uLINgIiAySMnuFJSrtldXBR EbI8T1c65ZIVJdBRf8mOtnhYyjGIEWJKDgEahw2RocWCnSSXFXelM2LWaJ29zq1+KTLuftjU ap3ie72UR4n5V1PlVJavds1374x3TwZzmjOX539xBnP+ePAOCDLFudYawLeM7tRAEa4TOP9q Y032yyikUk3bQEDSnOPrd57wa4idxDX+qwaW+QIL7Xec2KK6UkqCuPLwKNJRmCWt/89qws8x VnkAhUw4AOm3RXvcFzWAlg+OOKHdcsu9hoTYH1zVWtELlB+OO5DGo9ELMBpFVTmncQ+pcNJo w4tJ53QUq4RG26cp1zwr/DV9eRfSfhivirXVwKNazkjZZ9wAQvP/97vZAz08ycSSCGwsKMDT 3eIjGs3nbJrq9xeMfvr
- Ironport-hdrordr: A9a23:G2thjaP/QGKsmsBcTyP155DYdb4zR+YMi2TDiHofdfUFSKClfp 6V8cjztSWUtN4QMEtQ/uxoHJPwO080kqQFnLX5XI3SJzUO3VHHEGgM1/qB/9SNIVyaygcZ79 YdT0EcMqyAMbEZt7eC3ODQKb9Jq7PmgcOVbKXlvg9QpGlRGt9dBmxCe2Cm+yNNNW177c1TLu vi2iMLnUvpRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirC2Dlymh5rLWGwWRmk52aUIE/Z4StU z+1yDp7KSqtP+2jjfaym/o9pxT3P/s0MFKCsCggtUcbh/slgGrToJ8XKDqhkF/nMifrHIR1P XcqRYpOMp+r1vXY2GOuBPonzLt1T4/gkWSvmOwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze Ziw3+Zn4A/N2KOoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vFqLA BXNrCc2B9qSyLbU5iA1VMfg+BEH05DUytue3Jy9PB8iFNt7TJEJ0hx/r1qop5PzuN5d3B+3Z W2Dk1ZrsA/ciYoV9MOOA4ge7rANoWfe2OEDIqtSW6XYZ3vfUi976LK3A==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Mar 08, 2022 at 03:44:18PM +0000, Jane Malalane wrote:
> On 08/03/2022 11:38, Roger Pau Monné wrote:
> > On Mon, Mar 07, 2022 at 03:06:09PM +0000, Jane Malalane wrote:
> >> diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h
> >> b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h
> >> index 9119aa8536..5b7d662ed7 100644
> >> --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h
> >> +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h
> >> @@ -220,6 +220,9 @@ void vmx_vmcs_reload(struct vcpu *v);
> >> #define CPU_BASED_ACTIVATE_SECONDARY_CONTROLS 0x80000000
> >> extern u32 vmx_cpu_based_exec_control;
> >>
> >> +#define has_assisted_xapic(d) ((d)->arch.hvm.assisted_xapic)
> >> +#define has_assisted_x2apic(d) ((d)->arch.hvm.assisted_x2apic)
> >
> > Those macros should not be in an Intel specific header,
> > arch/x86/include/asm/hvm/domain.h is likely a better place.
>
> Actually do you think hvm.h could be better?
I guess that's also fine, I did suggest hvm/domain.h because that's
where the fields get declared. I guess you prefer hvm.h because there
are other HVM related helpers in there?
Thanks, Roger.
|
