[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jane Malalane <Jane.Malalane@xxxxxxxxxx>
- Date: Tue, 8 Mar 2022 16:16:21 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9BrTw2P807BlUNiaWeVrBK2zTf7ICJnk2VvsQOBaIP4=; b=YKVPh6tc2bYp3i9Irz+k8uWl5B/8eBm7ACaUgDZPRQ8xE784Qt5MfvQquCxllLLRpEtPEVNxAZePpgpCrbmpI+I6S3Nf+nb0AO3x2xTwG2/ZArTt3T+NJ6LLcEjMoHAe0wPBAfoBoaCUKkaVuj1czveoWID1uygOxe5zrLPu7l91VDC1cwCocFxCZDdyxlJDBoVrCiREYllBiy8qk6p3uS53Wx+3juKFJw/SRSrGcPwHePonmYbDuk5xIFhMgr3Xq9KhWO10UJ7YORzGVGW7/aUFMWGfhrdi6h9G4Z80lGllMO5FuBHVltZYz7UVTW9cz2fRC0DlMPRO1B58kTRW8g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U0IgoaBIbmBo/DKfUtYXlbVo/AGO+QmFTCrTDImG5po9Y4h+ft6Lx5zwxGs3ULTHjbwhYwJ+uZ3XTlnpehq7eURK1qTzjM8LTAGe38zd3vmCADvxkPtwgbr2M6fDTO+C6EPr943BQBfFDq7thwPSi8/eL58J4fE9mq6B2g4sQ/J9s7UDaNfrDzyILEvVWcl+9iSSL+FUI789rVDmz/VORN7lIdgxyduGJ7rAqi846Ff85K7L9W404pFcYX1DASW9vh36mqUHSc5v9R85GIXw+J0QkRR21mamCMteJF9MdO8ptlnT6mytU8abvSdTQUTOgrPeFZSWw+p9lJ26BsApLA==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "Anthony Perard" <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "Andrew Cooper" <Andrew.Cooper3@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 08 Mar 2022 16:16:30 +0000
- Ironport-data: A9a23:8PWc+6LMF4oiA4HLFE+RKZUlxSXFcZb7ZxGr2PjKsXjdYENShjxRm GVKXjqBOPzcZWTzetoiOt+2oBlQupDQz9M1GQJlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh2dY42YLR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 NoWhLGoQCcbBazFiLwgVTd0ISZ3FJQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq 6ZecmpUKEne2aTmm9pXScE17ignBOviOo5Zn3hkxDXQC/sOSpHfWaTao9Rf2V/cg+gQQ6+EP pFHNVKDajzPWUMTA1NKJqs4s9qkvUnucy98lW+a8P9fD2/7k1UqjemF3MDuUseRWcxfk0Kcp 2TH12f0GBcXMJqY0zXt2nCxgu7CmwvrVYRUE6e3ntZUh1mUyn0WGQchf1KxqvmkiWazQ9tab UcT/0IGoaEs+WSxQ9L6Xhn+p2SL1jYDX/JAHut87xuCooLE7gDcCmUaQzppbN09qNRwVTEsz kWOnd7iGXpoqrL9YXCX+6qQrDiyETMINmJEbigBJSMH7MPku5oblQ/UQ5BoF6vdszHuMWium XbQ9nF43uhNy55Qv0mmwbzZqz33l7XRRy4H3QTeTjqY6C1VVomsTrX9vDA38s18BIqeS1CAu l0NlM6f8P0CAPmxqcCdfAkeNOr3vqjYaVUwlXYqRsB8rGr1pxZPaKgNuGkWGat/DioTldYFi mf3sBgZ2pJcNWDCgURfM9PoUJRCIUQN+L3YuhHogjhmP8AZmOyvpngGiausM4bFyhBEfUYXY 8vzTCpUJSxGYZmLNRLvLwvn7Zclxzol2UTYTo3hwhKs3NK2PSDJF+laYAbVN7Bkt8toRTk5F f4FbKNmLD0FDIXDjtT/q9ZPfTjm01BhbXwJlyCnXrHaeVc3cI3QI/TQ3akga+RYc1d9zY/1E oWGchYAkjLX3CSfQS3TMywLQO6/DP5X8CNgVQRxbAnA5pTWSdv2hEvpX8BsJudPGS0K5aMcc sTpjO3cWqQfEGqWoW9BBXQ/xaQ7HCmWacu1F3PNSBA0foJ6RhyP/dnhfwD18zIJADbxvsw7y 4BMHCuBKXbfb2yO1PrrVc8=
- Ironport-hdrordr: A9a23:riy47KpLFigVerZwSI08NQYaV5rReYIsimQD101hICG9Evb0qy lhppQmPH7P+VIssRQb8+xoV5PufZqxz/BICOoqTNKftWvdyQiVxehZhOOP/9SJIUbDH4VmpM VdmsZFaeEZDTJB/LvHCAvTKadd/DFQmprY+ts3zB1WPH9Xg7kL1XYfNu4CeHcGPzWvA/ACZf yhz/sCnRWMU1INYP+2A3EUNtKz3eEixPrdEGc77wdM0nj3sQ+V
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYMjUEaMoAwzVpzE69n4F8Ciyydqy1XcmAgABEiACAAAUagIAAA9uA
- Thread-topic: [PATCH v5 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC
On 08/03/2022 16:02, Roger Pau Monné wrote:
> On Tue, Mar 08, 2022 at 03:44:18PM +0000, Jane Malalane wrote:
>> On 08/03/2022 11:38, Roger Pau Monné wrote:
>>> On Mon, Mar 07, 2022 at 03:06:09PM +0000, Jane Malalane wrote:
>>>> diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h
>>>> b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h
>>>> index 9119aa8536..5b7d662ed7 100644
>>>> --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h
>>>> +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h
>>>> @@ -220,6 +220,9 @@ void vmx_vmcs_reload(struct vcpu *v);
>>>> #define CPU_BASED_ACTIVATE_SECONDARY_CONTROLS 0x80000000
>>>> extern u32 vmx_cpu_based_exec_control;
>>>>
>>>> +#define has_assisted_xapic(d) ((d)->arch.hvm.assisted_xapic)
>>>> +#define has_assisted_x2apic(d) ((d)->arch.hvm.assisted_x2apic)
>>>
>>> Those macros should not be in an Intel specific header,
>>> arch/x86/include/asm/hvm/domain.h is likely a better place.
>>
>> Actually do you think hvm.h could be better?
>
> I guess that's also fine, I did suggest hvm/domain.h because that's
> where the fields get declared. I guess you prefer hvm.h because there
> are other HVM related helpers in there?
Yeah, that is why - tsc_scaling_ratio also gets defined in domain.h for e.g.
Thanks again,
Jane.
|
