[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 15 Mar 2022 08:40:24 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dQGHfPhFLIgM6vRyHj6xjcp5iy3AxVUs608c3Pon0PU=; b=hjHVphlaVCOWkpXlvDTyH9lYcLKwjG01/BZV7CJk4zER1V82u9Msvq0M0tvtE7nI/EXO0+C96bAfSdnQWOa4Ei+upeTceQrHdQXChTQXvVkdukNetknBjcS92/Mmkx0MJl4x3VDh67tgaQ1WUb7xuc5gXrQFkkQfI2us9JU19kxUQAyOArsg2bNOBTUOyvcUiAbK4wYpkGhq0eFIdAKYex6Rba36/Xq4YTLxJn/gsgMkPmcQ+G/Gx8yDBhKy7mrqf8BxoR12j/XmvjIqitxoEh+zorCJbJsRj0Aq/Y5buBRnp0AuSbqnS6zDCHz4oN8F2a/Y0+XM/3HJgV+YVk2AdA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oc2d9S5kb+0ac4HAPrFGjYBb46pMqHT8NpCukp2Vma9VXpq7ZMpGg476pj1Z5eOkYitDxbszLTdUefxIIV/zaw5AI0EH8yTo5871ALENJjSAyF4NgCK2pL8T5Gt5MkfOiG6aDMxntumyJhas1HcvPmgcE1F7lux1dCosQ6rbJHzX9ns6hw5aEMxD3YP9b7Jrv1vaWokvmQ63tJa6TceKyKIS/I+uCQja77R6HBOpdFf2YWRV9YR2J2mMGKJgwgQ2QgKtTBIC6YILmorL8nw+T/nGHypX87RQsHCSO2I+mgdrwcVbtDEAQOZKvE9bItxJkaYlR+to4LnrXMu7kJ2VYA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>
- Delivery-date: Tue, 15 Mar 2022 08:41:14 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYNKHSvTK6bj2+f02v/DWZHCtE9qy5jxyAgACrU4CAAKeKgIAFGdqAgAAriQA=
- Thread-topic: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time
> Hmm, this will fail the ASSERT(spin_is_locked(&cpupool_lock)) in
> __cpupool_find_by_id().
>
> I think you need to use cpupool_get_by_id() and cpupool_put() by making them
> globally visible (move their prototypes to sched.h).
Hi Juergen,
Yes I was thinking more to a __init wrapper that takes the lock and calls
__cpupool_find_by_id,
this to avoid exporting cpupool_put outside since we would be the only user.
But I would like your opinion on that.
Cheers,
Luca
>
>
> Juergen
> <OpenPGP_0xB0DE9DD628BF132F.asc>
|
