[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] ns16550: Add support for Intel LPSS UART
- To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 15 Mar 2022 10:04:34 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yr3wtAgn6fDHoSE6/i4LwSDxC4WhrsFiGbmPYwV+CiY=; b=Q6YrMOa95L/5dBkMXpyTwW6rrAUS+FNPreFHvpt8OO2+G4+h30kzvfyhyAmqjiXtKLcIVatId37Xq7qqClEm5LS0bIUcY6LRvrW2Vd+jhcQhQHf2+XOyeBElXU9GgmvrOa1pxmJoxAjyB4e5fHLEHkjrTQiaIzvXdgPrnjvVZxaheqOe+G1+PVP04Mv7cPnFsIGtXRa1USI7iKkEfY9AgXSSkexZRYRrf6g+J3Oo/e5ruzKWFR9I7kGfdDtep6XJ2wzgQrgZ3F06Rav3wR0GMVfy83CTjucgRpPVThxrqaBF+jgdLURHLou8x7pW7WQWKBdNjCEuh7nkzw3tRERj9Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JT+Wgy59GakRrZ7sXgDZ7JPiggBQkVOXxhnTWlNL2R/vSeZtUIP7S4BVnxHMW+oVlXKwGiPghgphaqYTOPeV3HBRTyqc00s77hOcZ/q2ASahBKjqCgUKhKPxp8aqYTGf9OVTc+9TLbYYcqcTnfgWiJBsfovDX2YApScDARAj8Nc8fIaF0jEBI4Z9jGd6qTRNuqv26V5t7uccecSumXwsoSVIV4dcr9xiFa8P47rvZZJbrO3u5CR0ca5SaAwHXUZXGYh2ANvNMTR2geVLHpSRFCUTh6NsZiDhCGdLzmLHimv/xB0wnXNfACHXj10ydAkARn+VJtON00BIbZ8r4Bb5yQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 15 Mar 2022 09:04:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10.03.2022 15:34, Marek Marczykowski-Górecki wrote:
> This adds support for serial console as found in a laptop with TGL-LP
> (StarBook MkV). Since the device is on the bus 0, it needs to be enabled
> via "com1=...,amt", not just "...,pci".
>
> Device specification is in Intel docs 631119-007 and 631120-001.
>
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> This adds only a single device (UART#2) to the table - the only one I
> have present, but the specification includes other device ids too. Should I
> add them too? I don't have a way to test that, though.
Personally I would have added the other ones as well, likely even going
further and including those from the other 500 Series variant as well,
and maybe yet further including e.g. 600 Series IDs too. But if you
want to restrict this to what you can test, that's certainly fine.
Jan
|
