[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] xen/grant-table: remove gnttab_*transfer*() functions
- To: Juergen Gross <jgross@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- From: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
- Date: Tue, 15 Mar 2022 20:52:11 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D5oGmtdNMTtm5LFPAJodjB22eG2v5qOL+g66G6N6cVo=; b=atz74ony4w9QefwUs1T5OaO4mE3bUPcWwqB2ymscUHFoP3Xs1F/2TR9EFE7jHIgIqwdP+z60aKik2zTuVDhKrgEAcYY/benuVxcIOsVz78fOZK/f6UQilmyISBETbbSAtp/aXa/+jCS2dCMwlZap8sugmSswgMO4aU6QEMC9DKYM+n18drGmiGBm/2pZGjU4V1Fa5f6uCNop+X/J8JOg3Wm9bPJBbg2ferqTzTivIbT4YBJpZDCkDiwUuc6v93C3W342YyvKuU6dJQ4b1C9x+QZDVF5y8NXqDEwq6P93aANKQUilstTjR7L0kRzwcZtFGzA/q+8lIoiaw2eJ5FlhmA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cZmB0YM4Y5Xjp2lDcXPf0qqLZTzNjbAI6gzICxgEd/VN9wgLBnxOncVdH6Fko/h8IoXFStnseAMiXY0FsyYPWBCxaHHh7/JUb7EB2TIHJNAexoJucc/UjFpV0uSk/jZFQolgUOw3xOx9s4PQ6jkaQrwN15Xg2XCDuiEJwum7KscTVLSuuNyPf3NOyvfwq5TO4VeURc14SMaXZQm+HWfxduAIoc4MCzKJ7OMJ+jhCuT/hiKNMvSb5kPVw4ICQ3+r4HGE5Qz4xPKY9xyoiyA2ybUiLOgLMqo9EAmcqqb+VKvqjrNobOs2TOggvaTt4pVLuIUSKYhaIihWNz/xN6xnxVQ==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Wed, 16 Mar 2022 00:52:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 3/15/22 2:10 AM, Juergen Gross wrote:
On 15.03.22 00:37, Boris Ostrovsky wrote:
On 3/11/22 5:34 AM, Juergen Gross wrote:
All grant table operations related to the "transfer" functionality
are unused currently. There have been users in the old days of the
"Xen-o-Linux" kernel, but those didn't make it upstream.
So remove the "transfer" related functions.
Do we need to assert somewhere that transfer flags are not set?
This would be an orthogonal change, right? My patch is just removing
never called functions.
I was thinking of having this done as part of code removal (maybe as a separate
patch).
In any case I believe checking those flags is the job of the hypervisor.
If an operation is illegal due to a transfer flag being set, it needs to
be rejected at hypervisor level.
True.
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
|
