Re: [PATCH 1/3] tools/xenstore: add documentation for new set/get-feature commands

[Luca Fancellu <Luca.Fancellu@xxxxxxx>]

> On 16 Mar 2022, at 16:10, Juergen Gross <jgross@xxxxxxxx> wrote:
> 
> Add documentation for two new Xenstore wire commands SET_FEATURE and
> GET_FEATURE used to set or query the Xenstore features visible in the
> ring page of a given domain.
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>

Cheers,
Luca

> ---
> docs/misc/xenstore-ring.txt |  1 +
> docs/misc/xenstore.txt      | 12 ++++++++++++
> 2 files changed, 13 insertions(+)
> 
> diff --git a/docs/misc/xenstore-ring.txt b/docs/misc/xenstore-ring.txt
> index f91accb5b0..bd000f694e 100644
> --- a/docs/misc/xenstore-ring.txt
> +++ b/docs/misc/xenstore-ring.txt
> @@ -68,6 +68,7 @@ Mask    Description
> -----------------------------------------------------------------
> 1       Ring reconnection (see the ring reconnection feature below)
> 2       Connection error indicator (see connection error feature below)
> +4       GET_FEATURE and SET_FEATURE Xenstore wire commands are available
> 
> The "Connection state" field is used to request a ring close and reconnect.
> The "Connection state" field only contains valid data if the server has
> diff --git a/docs/misc/xenstore.txt b/docs/misc/xenstore.txt
> index ea3d8be177..31e3d53c52 100644
> --- a/docs/misc/xenstore.txt
> +++ b/docs/misc/xenstore.txt
> @@ -332,6 +332,18 @@ SET_TARGET               <domid>|<tdomid>|
> 
>       xenstored prevents the use of SET_TARGET other than by dom0.
> 
> +GET_FEATURE          <domid>|                <value>|
> +SET_FEATURE          <domid>|<value>|
> +     Returns or sets the contents of the "feature" field located at
> +     offset 2064 of the Xenstore ring page of the domain specified by
> +     <domid>. <value> is a decimal number being a logical or of the
> +     feature bits as defined in docs/misc/xenstore-ring.txt. Trying
> +     to set a bit for a feature not being supported by the running
> +     Xenstore will be denied.
> +
> +     xenstored prevents the use of GET_FEATURE and SET_FEATURE other
> +     than by dom0.
> +
> ---------- Miscellaneous ----------
> 
> CONTROL                       <command>|[<parameters>|]
> -- 
> 2.34.1
> 
>