[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/hvm: Include interruptibility state in hvm_hw_cpu
- To: Tamas K Lengyel <tamas.k.lengyel@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 17 Mar 2022 15:03:14 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IidUIM65uQbzncJG4NWU9/gqsTs3GkMdv089SkFiGS4=; b=bewmQ2B1zh7W58BtRkZyWpB6V5RqCdxm0CCgXpdjVGPdS+KbNJLMTa4idu7Z18nx18sYudyV3deMHFUFDDZxgU8hhqj/eBAi4GuET3L7oaiOrgyBNto+rLeQGSY3gjOkqdMYPfwUVBGcgTi1OedzR5YJzlNoPWCZ8yHAaZNWlHPZXsd4bh/nOuyFdGbNXrsW5BIKTtedHVd8SXRSMkOZ3egXv7mVpCsk5zSnP3DybfucRglM+ho41Yx2082iLt6X0VrDB8Uk69SzW9sZuBaYDfuiz+lSV1Xy3lrCCQ/kE2huyJli4vBxFtiXR/GoHO3QuybyVem7jyraHu13yVcIzg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jcOQm4+9DGNRectS+0fOg9Ig/wvGqqMsqZCylLuir+uoDi4NqtHP7kBF6LObiIDPyykdGn4Tc0onl3XSa2vVUtt2d26yqPN4LP+eCROpSCghvlZEG0oLWvH4AvH4bQNZy+ReiEql7u0xB0UPGFEjxHoCRyy99M2wo5dHVu7sNTRaKdAN/C7S1XSglk5lNf1UknNjmOKqbto8mCl/9DJ3bt0M9glF1X3+Vwz9UVHDha8XQmbYwJ8Jfmq0eUkUxYQ3vZZ343GKm3KDfsr3U2Bv9PfTMUBEA/Nuuo4D4J7UFprQLGV32dFO122MOqSDwIWvsAM9wZV97PCrD54tNaJNCw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "Lengyel, Tamas" <tamas.lengyel@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Cooper, Andrew" <andrew.cooper3@xxxxxxxxxx>, Pau Monné, Roger <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>, "Tian, Kevin" <kevin.tian@xxxxxxxxx>
- Delivery-date: Thu, 17 Mar 2022 14:03:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.03.2022 12:06, Tamas K Lengyel wrote:
> Another question I would be interested to hear from the maintainers is in
> regards to the hvm context compat macros. Right now they differentiate
> between hvm hw cpu struct versions based on size. So since this patch
> doesn't change the size how is that supposed to work? Or if there are more
> then two versions of the struct? The compat version never changes?
struct hvm_hw_cpu_compat is indeed not meant to ever change. It needed
introducing because the msr_tsc_aux field was added in the middle of
the struct, instead of at the end. Going forward, as was done with the
"flags" field already, additions should only be at the end. Exceptions
are when padding fields are assigned a purpose (like you do), which is
why they need checking that they're zero when they're introduced.
Jan
|
