[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 5/6] arm/dom0less: assign dom0less guests to cpupools


  • To: Luca Fancellu <luca.fancellu@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 21 Mar 2022 10:04:35 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wzqsUEraQzLbxAKczaPbXHLk1rU4oaB5qv+1d5hDDyU=; b=Ng1JfZb4K/Ppzh8BnK4U/g+LkjZlIS2jSWl1cfTL5i0Etl6kU/qCeqMLnqXor1aGM/U8Upfp71I1nH/peivjVCSUQlae1cvkxIlvyIhBZV+gdo1ZsP325I5mcK5b1tqUwVCZQgr/BNZuTCh7EhA/RceSyArCdQ2F8SgNokBZJeoaiVqkYteZl28iseeV4hJ04FgYivtTEYhtV0ZJOFkwFCSSTYvmYuB04fL2U7LmAm8Q8M++W9NrtoZTTZI/+WKNkpb1Z/qTyymHqijqH5XasAZat5XrU58zsaEpWE8vCPTh+F7HitTKV3zHBPMvqqTlMMuXzk9zDW8dMatLOBA2MQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=leZK0PjkaO3rOqsvu5N1xOSXHxD8c+Df/Dgm5xqwDkNwOCdFpR55t14mBS642afCSh/dzGBiIip9qsezKrojz3trANQAFhNgq072/+vUr5S7CH6zI8YAFISCJwKpqUvlE2ANAyHi1cE8pI9aMyA/H9M6UDmP8uHmMsbS8rhSs4ujGFzwosPU/fRveXMzuAWP83ND+urUekmSCMF6dewPAnXLbw0UCTakofFPEMjUPXFGGgcI75kYKtfp2TfEvAhkwW4sQBBpa3d4cFBA8YcMJ03rx4eXZy0IPjrpakALuApyp1qERqjctM52kvu1xpMj+tnKSbl9UJz/ISUJHbiTmg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: bertrand.marquis@xxxxxxx, wei.chen@xxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 21 Mar 2022 09:04:52 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 18.03.2022 16:25, Luca Fancellu wrote:
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -1182,6 +1182,7 @@ unsigned int btcpupools_get_cpupool_id(unsigned int 
> cpu);
>  
>  #ifdef CONFIG_HAS_DEVICE_TREE
>  void btcpupools_dtb_parse(void);
> +int btcpupools_get_domain_pool_id(const struct dt_device_node *node);
>  #else
>  static inline void btcpupools_dtb_parse(void) {}
>  #endif
> @@ -1193,6 +1194,14 @@ static inline unsigned int 
> btcpupools_get_cpupool_id(unsigned int cpu)
>  {
>      return 0;
>  }
> +#ifdef CONFIG_HAS_DEVICE_TREE
> +static inline int
> +btcpupools_get_domain_pool_id(const struct dt_device_node *node)
> +{
> +    return 0;
> +}
> +#endif

Was this perhaps meant to go inside the #else visible in the context of
the earlier hunk? It's odd in any event that you have #ifdef twice, not
once #ifdef and once #ifndef.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.