[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time
- To: Luca Fancellu <luca.fancellu@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 21 Mar 2022 10:10:40 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CMe4OJc7AcknnkGTat9CoAxDfE6TL6bWk5RzmIdSnpk=; b=Q2Lvu9BMjSfRYOmFc/TKoXOslLcfMJ9U4oeseAPQUP7gBuT8ewH7VLkq8wLlmrcsyOg9T4WWo156AYOMobaMvYNw7oVnpEsLWOnhPWpgbvc6L0QD0ovKK2BHok8WYZynbz/jGheBCIXuhjdJ14wYPo5cXD+Lg99vIBdll1xvdKE3kJWSInuytbyoIJs8G36yz9Ii8/lbEGn0Vw8xzI2DYs3c7RQayE/Yx49VQL2o7jaBoXYtiZ9OJeDpxpsS6mY0CJLhiBUXNsXZcu9WWteQ1ChU7r26UIGovmIgow5F2H/Q4EM0GHqddVyVtRwWByLlq5GFR+RFzAv4QGTtD1dYBw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j8a8JqceswM+PFofitB9A04jsS4M+BbDSjncG3GXK4hxynFeQLO+M1WuaQD0S+NGKBaTW4flB4J41ewf4HRNsfUHnMoWU88dYs0loQPvElo1IRYOowCmDQ4TajGcubfuOscmz4YAwuilXDz1K670hPpzyu4rclLV+jimhLsrZluOacd7TxJ9BT0SAFpUhIrBa5FpsQEOnBP0IuAPd/NgSWRpoaH1ZwqcH2nmFROLZrEMII+g4rX//Q3sIRJvA5ImTnhmZk14gMIbd9uvCu2E4H/NWZtYq2SsZq1lCnV2RoDZDx+8aduNGDSzhApCqJGxO/nl1l0ijK52b/y+lp+7nw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: bertrand.marquis@xxxxxxx, wei.chen@xxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 21 Mar 2022 09:10:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.03.2022 16:25, Luca Fancellu wrote:
> --- a/xen/common/Makefile
> +++ b/xen/common/Makefile
> @@ -1,5 +1,6 @@
> obj-$(CONFIG_ARGO) += argo.o
> obj-y += bitmap.o
> +obj-$(CONFIG_BOOT_TIME_CPUPOOLS) += boot_cpupools.o
By the looks of it you appear to want to specify boot_cpupools.init.o
here: All functions there are __init and all data is __initdata. That
was string literals (e.g. as used for printk() invocations) will also
move to .init.*.
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -1176,6 +1176,25 @@ extern void cf_check dump_runq(unsigned char key);
>
> void arch_do_physinfo(struct xen_sysctl_physinfo *pi);
>
> +#ifdef CONFIG_BOOT_TIME_CPUPOOLS
> +void btcpupools_allocate_pools(void);
> +unsigned int btcpupools_get_cpupool_id(unsigned int cpu);
> +
> +#ifdef CONFIG_HAS_DEVICE_TREE
> +void btcpupools_dtb_parse(void);
> +#else
> +static inline void btcpupools_dtb_parse(void) {}
I think you want to avoid having two stubs for this - one here and ...
> +#endif
> +
> +#else /* !CONFIG_BOOT_TIME_CPUPOOLS */
> +static inline void btcpupools_allocate_pools(void) {}
> +static inline void btcpupools_dtb_parse(void) {}
... another one here.
Jan
|
