[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 21 Mar 2022 15:51:32 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HO9UQ3ob3jLfGND+gxvmNC+GzyGbY3efxpwulWkAt8Y=; b=ghpMW2Fj27VLYBbS1xGZjbdtWijkNVDVlEGknDVqNZKaCYuKvXcEROmdKUI0riCVBfCwe5gN8UvnlI5ZYzEv45tiKRy7DbMtYz94SLavnrgc0rL/mYdeew/ZjNbP9FobpzTDU7KNF21AqH9be+u8CjzN2dj8JyiJval73HOUAG9i5mgqb8/1sB+xVvSoDGbUyMyKwpfQ9sH/XSykI3NweFeyArHqTd+KuR6rl03DhRZc6S1XIUE7quASenDl/HrXS9RkPSkuBbfdSO9uUTrTbGPjKUQesDV6hDDBZnJI26pkLVnhWik7vzfKM5BDdv7A0t2g2zfadW7Bt+r1UdyZ5w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LYwIbFtut9CGV8wj3uXn4907gbttPuWOYQPUtSUi7JXozW19/WtETS5YhxNTJSqsXbnkBldPM7gkQrrRJ20l4PGnotX1UR9WdHHO7iCuWYqbopKubsOrRzF2M7Qvgf8rnVxlJ/DDOQRXwszIJzKbuUCtgNVG66TQUvOogsOI4/3blnF/eyNhM2+nsvQFFy4iHWsT5rAv7E404Gl4PHbeK7U7Eqv38yomRhsyTGQtSQ3c8uMchRKPMjUj5PY/TypYMgxkRmqJV+AoSi6wbwhb4c4bx3mDVys5T2zwHbZ+VnIjh6FkPgs4u1XRXCTfLI+Moxw1Tn+ozu7a2PDex5iEmw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 21 Mar 2022 15:51:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYOtySiWfuTiIQkkqv44WbBvDftKzJkVgAgABwAQA=
- Thread-topic: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time
> On 21 Mar 2022, at 09:10, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 18.03.2022 16:25, Luca Fancellu wrote:
>> --- a/xen/common/Makefile
>> +++ b/xen/common/Makefile
>> @@ -1,5 +1,6 @@
>> obj-$(CONFIG_ARGO) += argo.o
>> obj-y += bitmap.o
>> +obj-$(CONFIG_BOOT_TIME_CPUPOOLS) += boot_cpupools.o
>
> By the looks of it you appear to want to specify boot_cpupools.init.o
> here: All functions there are __init and all data is __initdata. That
> was string literals (e.g. as used for printk() invocations) will also
> move to .init.*.
>
>> --- a/xen/include/xen/sched.h
>> +++ b/xen/include/xen/sched.h
>> @@ -1176,6 +1176,25 @@ extern void cf_check dump_runq(unsigned char key);
>>
>> void arch_do_physinfo(struct xen_sysctl_physinfo *pi);
>>
>> +#ifdef CONFIG_BOOT_TIME_CPUPOOLS
>> +void btcpupools_allocate_pools(void);
>> +unsigned int btcpupools_get_cpupool_id(unsigned int cpu);
>> +
>> +#ifdef CONFIG_HAS_DEVICE_TREE
>> +void btcpupools_dtb_parse(void);
>> +#else
>> +static inline void btcpupools_dtb_parse(void) {}
>
> I think you want to avoid having two stubs for this - one here and ...
>
>> +#endif
>> +
>> +#else /* !CONFIG_BOOT_TIME_CPUPOOLS */
>> +static inline void btcpupools_allocate_pools(void) {}
>> +static inline void btcpupools_dtb_parse(void) {}
>
> ... another one here.
>
Hi Jan,
Thank you for your review, yes I will fix your findings in the next serie.
Cheers,
Luca
> Jan
>
>
|
