[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] tools/firmware: do not add a .note.gnu.property section
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 4 Apr 2022 14:45:05 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m5IOVzd+AUZ3xE5KkLU2uRKIhBi+56SI5faygOZqUSw=; b=MC9yFRl2lHRnXYwbQlkytkGb0KbuFgm5OBuy/XqMISDsRlplxhWuZnLDhnmbaFbTmcXFsF8NtL0NdS3Eafv5ibPb3pKU5KC9kFcvEHPgUlx0jsgnD8WY+oNTDIvzo6Ruqm8rsfTmjO/vOfd3lIktKoNw5I2k0STzm7EL5Xyop5uqY7gO1R5mCVxPYDlZNByNVKWefyBTJjiro33RIhsq/MAq4HDy0U64+BPj9oC7GHBJjErv3rvDIlJkqEN9tPUy3xaN7zztCR6jxrunLXuQMTExBRk4FdfkDvnPX1uHR+wlTg6Dh4B+UlI69mtxJ8TZWnWdjbMASEo7ptOv4Ou44Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DGuqr/WNEaV0PqHQ52N31gAY1zQwmxanRXphhtCchVxb+KBZAjIuKtkP1bvuqV2ICwQejJHsve9uf4rf8kZiVntpaiuU53aGNDxmNJW53+Y0wDFEIHeYX4XrlgPA8KfAOHLPxndjQ6aaBXKNJg0hA/F4SjRKp0bdmv0PzzgRhSroRi/EKUpp0i4Rji8c8A1OiqESOvItY+RNAix30qYwGGjlHB+R0OHrmNmCK8C8F3eOzGHLSvoqbx5K7kxH3RcAQTbxz8U6sXt5S9ekVa6FJ4mUNYpMcgM39o0yrNStp45gokXUSCHW/sIqntBhoC7FEdf4uDGFz8StehZltxpTmA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 04 Apr 2022 12:45:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.04.2022 12:40, Roger Pau Monne wrote:
> Prevent the assembler from creating a .note.gnu.property section on
> the output objects, as it's not useful for firmware related binaries,
> and breaks the resulting rombios image.
>
> This requires modifying the cc-option Makefile macro so it can test
> assembler options (by replacing the usage of the -S flag with -c) and
> also stripping the -Wa, prefix if present when checking for the test
> output.
I notice you've ack-ed and committed this patch, which I'm happy to
see. However, I don't understand why you gave your ack here, when you
did refused to ack (and to explain yourself!) for "x86emul: fix test
harness build for gas 2.36". Why is this note section useful there
but not similarly useful here (or, the other way around, useless)?
(This, as an aside, also makes pretty clear that - unlike the title
of the series suggests - this has nothing to do with gcc 11.)
Jan
|
