[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] tools/firmware: do not add a .note.gnu.property section
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Mon, 4 Apr 2022 14:00:27 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oXPkygFoJY55e+SWucnOmDTiQ0SNIKUmYAAayH0bJjc=; b=dEEEexJFFFqiV9mHjo3lOnzKlftE8kSfufuWsRrlkJk5UcULj6wcTs4py57L4PLx2sChI8kKxOn4X3iAKmfPPx+A+8NmYzIGFniml806SL1/jGL9gpZWFU4JbyfFV5ItcL0qqWoSiNvi6kaev2DE4XNM00KjYswVgf1uKxobkA8IuhtmY3ZBE5aJGfVRQ3X6jeBZPrTz4j8KrmQ/kJ299yfF7Nk43zyW0YLQmoRseTzrkyvP4y78XSKpU9TmPC0it/qxKWTqcxuyOAJTXms9i2jfrgRikoZVV4HumBi49aRldLkxtGygcg3uGKjYYpdpe4Zeqx3bpxakGADyrt0djQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KKb+eHiTZ/B/VGdXsbj4Ks7zQ9uOpEDaQqweB5seCC0FZwGOffUUpiP4IY6KZamnsRpjD1WFGEQBfKUc+zHREzN0JmnENo2HQpiDqjeAgDNFKQwaLXiJECja3y0pX3ZQ9WqWm7K5jTzcgPct+zepxRewryxVlrNnr1E2edb6rZevgZxKskknnqdOvjjF/R7TipFDg7gzgpe8N1wpvIq6lzAZDd4/u0yrK6nHHOQT8Syddix43kW0UCCxbELxlXPYtUQv8tEpZ0thvuY6PThwC5ZHJAhwRAwt7MS08oVaGh/8zch/QBCTXdPSXJYk7wXUfmjzni2NtNbqyofuj/xQBw==
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "Anthony Perard" <anthony.perard@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 04 Apr 2022 14:00:42 +0000
- Ironport-data: A9a23:UPB8UqMt7QUBOYrvrR2fl8FynXyQoLVcMsEvi/4bfWQNrUpxgjIEy jMfXmjVOPrfN2Sgc9x1PN7koB5Sv8KHxt9kTAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2tIw2LBVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z4 cRuq7eAFzgQII7ywsMvVTV6LQ19IvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQQqaCP JZANFKDajzgRQEfZ0w3Fqk+nb6Uu3ruMDZFqBGs8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv G2u13T0BFQWOcKSzRKB82mwnanfkCXjQoUQGbaksPlwjzW73XcPARcbUV+6p/iRiUOkXd9bb UsO9UIGr6I/6UiqRdnVRACjrTiPuRt0c9hNF+w37imdx6yS5ByWblXoVRYYNoZg7pVvA2V3i BnZxLsFGACDrpW8WFGD3YfKkgqsGhZPCl0ESQ06YQgatoyLTJ4IsjrDSdNqEaiQh9LzGC3tz z3ikBXSl4n/nuZQifzloAmvbyaE48GQE1Vrvlm/sneNtFsRWWKzW2C/BbE3B95kJZ3RcFSOt WNsdyO2vLFXVsHleMBgrYww8FCVCxStbWa0bb1HRcBJG9GRF5iLJ904DNZWfhoBDyr8UWW1C HI/QCsIjHOpAFOkbLVsf6W6ANkwwK7rGLzND66IP4IUOsQsKFTboEmCgHJ8OUi3zSDAdollZ /+mnTuEVy5GWcyLMhLoLwvi7VPb7n9nnj6CLXwK5x+mzaCfdBaopUQtazOzghQCxPrc+m39q o8HX+PTkkk3eLCuM0H/rN9IRXhXfCdTOHwDg5EOHgJ1ClE9Qz9J5j646e5JRrGJaIwOzbiYp ijtAxAAoLc97FWeQTi3hrlYQOqHdb50rG4hPDxqOlCt2nM5Zp2o4rtZfJwyFYTLPsQ8pRKoZ 5Hpo/m9P8k=
- Ironport-hdrordr: A9a23:XAgVQK97p/eWyO/YoYtuk+F4db1zdoMgy1knxilNoENuHPBwxv rAoB1E73PJYW4qKQ0dcdDpAtjlfZtFnaQFr7X5To3SIzUO31HYbb2KjLGSjAEIfheeygcz79 YZT0ETMqyTMbE+t7eG3ODaKadh/DDkytHSuQ629R4EJmsGC9AC0+46MHfgLqQffngdOXNTLu v62iMznUvYRZ1hVLXcOpBqZZmnm/T70LbdJTIWDR8u7weDyRmy7qThLhSe1hACFxtS3LYL6w H+4k/Ez5Tml8v+5g7X1mfV4ZgTssDm0MF/CMuFjdVQAinwizyveJ9qV9S5zXIISaCUmRMXee v30lAd1vdImjXsl6aO0ELQMjzboXITArnZuAelaDXY0JfErXkBerR8bMpiA2rkAgwbzYxBOe twrhGkX9A8N2KxoA3to9fPTB1kjUyyvD4rlvMSlWVWVc8EZKZWtpF3xjIeLH4sJlOz1GkcKp gkMCgc3ocgTXqKK3TC+mV/yt2lWXo+Wh+AX0gZo8SQlzxbhmpwwUcUzNEW2i5ozuNwd7BUo+ Dfdqh4nrBHScEbKap7GecaWMOyTmjAWwjFPm6eKUnuUKsHJ3XOoZjq56hd3pDmRLUYiJ8p3J jRWlJRsmA/P0roFM2VxZVOtgvARW2sNA6dg/22J6IJzIEUaICbRBFrEmpe4fdIi89vdvHmZw ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYSBCQ6RH62CeSa0GAvBWgl8BYdazfs3yAgAAVD4A=
- Thread-topic: [PATCH v2 2/2] tools/firmware: do not add a .note.gnu.property section
On 04/04/2022 13:45, Jan Beulich wrote:
> On 04.04.2022 12:40, Roger Pau Monne wrote:
>> Prevent the assembler from creating a .note.gnu.property section on
>> the output objects, as it's not useful for firmware related binaries,
>> and breaks the resulting rombios image.
>>
>> This requires modifying the cc-option Makefile macro so it can test
>> assembler options (by replacing the usage of the -S flag with -c) and
>> also stripping the -Wa, prefix if present when checking for the test
>> output.
> I notice you've ack-ed and committed this patch, which I'm happy to
> see. However, I don't understand why you gave your ack here, when you
> did refused to ack (and to explain yourself!) for "x86emul: fix test
> harness build for gas 2.36". Why is this note section useful there
> but not similarly useful here (or, the other way around, useless)?
TBH, I'd forgotten that patch.
This work of Roger's came from a real XenServer regression which causes
RomBIOS to explode. It needs backporting.
In the longterm, I would like to see us use real linker scripts for the
artefacts which have custom link requirements, because this is still a
bodge.
~Andrew
|
