[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools
- To: Luca Fancellu <luca.fancellu@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 8 Apr 2022 11:10:48 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W1xeU0RmUz3RtNke3MQimnA6qk3rju1aPUVKx/AKLNQ=; b=TElOycPDHW9M2nEqw384wUa/a+TkQfvzZUnjE0ngacNnBSYVAftp1fzlpZoKA+K1fAu04MljM5902ZUa/GC8sapz0FVdInBhpCQ5kax2wQXhuGWcy58+w0t1Vl/OLEWrBFbHcGbyQiFFJEtFr5JuVAJud0x833/8k7omgPl58JoZlmAeINruuD+2vtZwOnRDhYxFZGH4JtvsGCOWVohjJcVRAQN57RjDopDSUIGqdtaGr0xXN4trzlgMHqlFQj0wj58GbsmkeXrJlraLqLXZg43nRyQs3s6XdKC23Z31Z2G2JPvJUT2DgXsYWB6Yt0VoGHH8F1NM0JhtnxhErTCbLQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VgmtBEN2WTkxY05PCxcHZuKYKBPbAwqbBdi0AEg4bVwHlbSMxzAMNwVic9KE5eirXmHJeasmJVZpqB5/MYY7gSvWP9z648JW6J9+KlmOl+IcdKhRwiK3MVYPSX9PnroVRev6xm8qY80HZz9XD3l+/kWwBYczP1ptp1iYA5DNapmAurxYxwT38d5YC1amffTpq5iZiaJW6RPT2awFJhhEeCz0Em2EAzE4ZTsKcOlCwNCyWJNA1alxIAs7YShnwW6NsGoBJ3yR6FCpj3kZgInG5us7ifBUMWe8wpnWhcb1GAuJvH4AvpYphmgxI36hUGEpSOPr8CsAV5dqc0nDGrsK7g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: bertrand.marquis@xxxxxxx, wei.chen@xxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 08 Apr 2022 09:11:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08.04.2022 10:45, Luca Fancellu wrote:
> @@ -106,6 +106,8 @@ struct xen_domctl_createdomain {
> /* Per-vCPU buffer size in bytes. 0 to disable. */
> uint32_t vmtrace_size;
>
> + uint32_t cpupool_id;
This could do with a comment explaining default behavior. In particular
I wonder what 0 means: Looking at cpupool_destroy() I can't see that it
would be impossible to delete pool 0 (but there may of course be
reasons elsewhere, e.g. preventing pool 0 to ever go empty) - Jürgen?
Yet if pool 0 can be removed, zero being passed in here should imo not
lead to failure of VM creation. Otoh I understand that this would
already happen ahead of your change, preventing of which would
apparently possible only via passing CPUPOOLID_NONE here.
Jan
|
