[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Fri, 8 Apr 2022 09:39:12 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hpk+DkCtsLrRIBk7beMxpcNnE8UXtlXQ+7cDI+RfkFc=; b=gO2tGKJtoh5rOZ23im49wsLNkgZFy6szTG3NzWupoch6QssUArRO94lefg6NwfaEW9LVRiuyp2/y5CKIzxGVSLkyqfAqLropXHZyqL+eRxE+oMNS4v/oi7xZCrrjxfXmPIAMGMA+0pDPL7JeprIcIcDTp4t+ycvtT+2uEzXbJNLha+hBunyQD4e0X+/bb5ZSlX/XkHo+wXU/jdfPOO4n5pdkcpZxXxfkKCVkIW474fCNQYKwX9OFqN5LH64WUceCW/pbQcgP5OO3ffaJeoX2chgCc9khfBd36fIKqvpYRDVEz8PjZFsXsHTVOC7sXM++aPEU333QnegTe7G3xCUYKQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c4+7l25TNujyxCK7SC5oJPnNqfyFsfiatt/DDT3o1WKc8tl2cmG5eMfuYcF4xNtTm9IfC+aDjEGCbhSeyerNivBifisu+fzlahyvf97lZHxrrbIwdVDNI0Z2Tiyrq+fxCNBxlgmrwdrVNutO60iYuHMjIZ+l2/70URmH/PkiLlPsO34ot1p7L9SKHYwGLH+4YgiKhGnOF1cIlmNA/RJMkvY5EYB3/dj5ZH6SbV3dIK5iVsu3cJj37dQE7cOaibMJQ2SBRedPOq9YUmFAQvvDcdrOJf9/4Bn76sWU53BW7PB5Cd832Gk2tFIlqLMn6Hwo+1klbJBULnYTMNjB+AJ5Zg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Juergen Gross <jgross@xxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 08 Apr 2022 09:39:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYSyUS0CLVSvR2nk+ITbzc2Ry0wKzlusgAgAAH7oA=
- Thread-topic: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools
> On 8 Apr 2022, at 10:10, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 08.04.2022 10:45, Luca Fancellu wrote:
>> @@ -106,6 +106,8 @@ struct xen_domctl_createdomain {
>> /* Per-vCPU buffer size in bytes. 0 to disable. */
>> uint32_t vmtrace_size;
>>
>> + uint32_t cpupool_id;
>
> This could do with a comment explaining default behavior. In particular
> I wonder what 0 means: Looking at cpupool_destroy() I can't see that it
> would be impossible to delete pool 0 (but there may of course be
> reasons elsewhere, e.g. preventing pool 0 to ever go empty) - Jürgen?
> Yet if pool 0 can be removed, zero being passed in here should imo not
> lead to failure of VM creation. Otoh I understand that this would
> already happen ahead of your change, preventing of which would
> apparently possible only via passing CPUPOOLID_NONE here.
Hi Jan,
Pool-0 can’t be emptied because Dom0 is sitting there (the patch is modifying
cpupool_id only for DomUs).
I thought the name was self explanatory, but if I have to put a comment, would
It work something like that:
/* Cpupool id where the domain will be assigned on creation */
>
> Jan
>
|
