[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools
- To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 8 Apr 2022 12:24:43 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J8ORu/hmTr7dlvtRyRsBP40DOzjbltA4Il3DUI1S7jg=; b=mvRoR1H/f4g/XFEfWju3FSzHNNX82zMdvRfL7Ds9DG0GjhDu+WHLLgsoDNuCt7krByjXseMzHxx3VKQMdcQYe55Kn623ScAoG53wasD01QDNJB9iJyCr232HSJGGXOUOBBNxBBW0z9Dh7ZI1f5Giu1SBr951IHA75VmElPxAf+3ZhcGhiLqM/4vqmKw1zUNFVLMX64fmqyDCghMmMDvmZ73H2F89uQmPfKNzXimRYzuij+xGS4bFhAHA7leSWYmoKL2uBnUf7CTmcp4U5iSAqjSOkeko/GAw7foEIF0Ap1haHrnkEmKA3BnVGDScDNjz0AoQKj7aaZFOYCuJ/dN4YA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FznU9IKrFpyHARVP8ItGWmZneLQdAlKQJgTOABJiuSF9hkRrpkk80vwkNfYnmkGsfUBwpuyMiVqSyelp9iApxnYSdWDCQadZMOcKrbPEp59g0yGnup4FxVvqelkoc2J2wNqig18ZIxotfY88bYOeUy2QqG75No0oMiySx4Arqr8/sT7+9m1KneBd7AaQfK47n5kvFb53DrQFwIb2zqiwqqe+ay9/qOhjESKXe1zEHiqoyjNOjbTsMAIfuyJGFFid/mniLzskE5F8YMaSAVhM6BLT6++KY75Ef/suECfzKtet60oFV54fbB7T6johgfEGx3mYUL93W4EdSzd29SnYGA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Juergen Gross <jgross@xxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 08 Apr 2022 10:24:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08.04.2022 11:39, Luca Fancellu wrote:
>
>
>> On 8 Apr 2022, at 10:10, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>
>> On 08.04.2022 10:45, Luca Fancellu wrote:
>>> @@ -106,6 +106,8 @@ struct xen_domctl_createdomain {
>>> /* Per-vCPU buffer size in bytes. 0 to disable. */
>>> uint32_t vmtrace_size;
>>>
>>> + uint32_t cpupool_id;
>>
>> This could do with a comment explaining default behavior. In particular
>> I wonder what 0 means: Looking at cpupool_destroy() I can't see that it
>> would be impossible to delete pool 0 (but there may of course be
>> reasons elsewhere, e.g. preventing pool 0 to ever go empty) - Jürgen?
>> Yet if pool 0 can be removed, zero being passed in here should imo not
>> lead to failure of VM creation. Otoh I understand that this would
>> already happen ahead of your change, preventing of which would
>> apparently possible only via passing CPUPOOLID_NONE here.
>
> Pool-0 can’t be emptied because Dom0 is sitting there (the patch is modifying
> cpupool_id only for DomUs).
But we're talking about dom0less as per the subject of the patch here.
> I thought the name was self explanatory, but if I have to put a comment, would
> It work something like that:
>
> /* Cpupool id where the domain will be assigned on creation */
I don't view this kind of comment as necessary. I was really after
calling out default behavior, along the lines of "0 to disable" that
you can see in patch context.
Jan
|
