[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/build: Fix MAP rule when called in isolation
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 21 Apr 2022 18:09:33 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DVq+6whEiLRJ7xHIrr30WCcB1pdiXOMTm0IylIrQNGA=; b=A8EZctFhMpt1c0b44Pqkvv/MACS4H/Yc/ZvYyJ98WgHSTE6xqIVf2IemjDDO4dp4bY66j9Jd5/z17SA0UG5ubQwCCcbRoWUH40HitEyyAGW0ty+NV2mNYmRn4Q3WwPLmKc9n0fbpHpTfiSxPYiIiLyjAeT3AxDjsJZ1qGVWZLRiFdFY7FPv2DfiH7+l6BymV6kYXQ7bJuifZiQD4FaxYA/7RWfEMGtumVjZNzEZcaFL+9N4MMKCEOKgI9XLTwF0PqN4kNgvs/xlqmG95fxwrJeupYCB0KBLDrTCsH9C3WX7fTuMBFz2XnQJJ4cBLqlhO5DSzMax4KqEj1NoBZECL2w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S+XuimSuMUcY14xZ9MpTohKs5KBkmKfSsIRbGma/i8/J2uKgAtzv2Ci18lLVdqPgg/sHbbmmx3xVBt58fj4l8rn1GvFAQgCjwzap/btE39GSXZ/pPApJxdfht9Q2ZpxLXb23cVs0CUvRDtbD+18qmfYM5MZOqP/KxiM/yqU7KxY9xxZx498tYEj4cpDmhLogttQuRaWQtfT+cT2vvTUJ+tsQWvuFhZxChQymQ15c12b+VIpA+bmk5RTiGUDBEM7R9jVhrPwChmqE5mggQ2t3ZmXllq5N5DYfVEuX+CuvjQ4xiYJFoNm/k387xuveSuVnAxSleTpUHc8aE4tH+WaJ6Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 21 Apr 2022 16:09:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 21.04.2022 18:00, Andrew Cooper wrote:
> Now that `make MAP` might rebuild $(TARGET), it needs removing from
> no-dot-config-targets.
Which raises the question whether the MAP target originally was
meant to be used only on an already built tree, which would
explain the missing dependency that you added in the earlier
commit.
> Otherwise the build eventually fails with:
>
> CPP arch/x86/asm-macros.i
> arch/x86/asm-macros.c:1:10: fatal error: asm/asm-defns.h: No such file or
> directory
> 1 | #include <asm/asm-defns.h>
> | ^~~~~~~~~~~~~~~~~
Why would this be? asm/ isn't a symlink anymore, so should always
exist. I would have expected an error about .config or
autoconf.h not existing, ...
> Fixes: e1e72198213b ("xen/build: Fix dependency for the MAP rule")
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>
> Backporting notes. The original, e1e72198213b, wants backporting as far as we
> can go. This patch is only relevant from 6c122d3984a5e onwards, so 4.14,
> which is why my main developing/testing on 4.13 didn't spot it.
... and the commit you reference seems to support that expectation.
Jan
|
