[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/build: Fix MAP rule when called in isolation
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Thu, 21 Apr 2022 16:42:42 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mBsW/ApJfYyBb1g98+1L1ledW7RTkyKYxJpQcL2Hxz0=; b=mgLALSQs0GfZPpR+Eg2I5+dtfJZmwxcmJIHVCvIj86oCDblNy4d5/n7hSW24JXn5oXFduTguBfZUJPLkNwORVTbq59pJjp9useWXu9K1r7b4sUywJEVnH/7PEd8lt0lunm9wA+lW8YzSLmwlN/Nrbb+3ay6xawiB0vQ1GWKJ3ezfTeE6zmlxukIPYzFyXpR7NOWjJCNMlE/fKJAcl2UCfEc6V9juBnCRcH8l+G831QyW6stNf52dpG+h5jJRG/XBpOX8U0LvTbjrLleAP+8gjNmkAD7PI/B3lRqbY2OeuxAHL8lWJ47KslMYcqL9YOfv/q/G0bL14A11ne29AaaifQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BeKV3VigGAfCaNJ3KcVVlK2+jpL3cIfQ7g/AVU91oBursOtYetqT6nkUFbJL4iJ+CT0Zi/02TNz+c5jP9M006MdXebWS91vvmVtcHkUv1mOcOtEteMNhyiBXA8PWwXr2ouiGxtWLFzoDYstFO4KbWrHGOXb66u8xMbMuMAe9JmVUHHk36h8Pt4uHe0oSPyNRFtIgc5pyb3KbQ0aBnr+siKtJXE5wEGwYxXQHHfnRKNPRM+xDYT5dhsm0B4+Y7j3J9HavhoOVAhAozLt2L2F8FCVU8KdJtK6ceTSIAVdCMvpzZfvXd1xm3alN5zyzM1OBbW4c0VeL7vuE0Ob7de+YpQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 21 Apr 2022 16:43:10 +0000
- Ironport-data: A9a23:43ZKQKONA/zFn+7vrR3KlsFynXyQoLVcMsEvi/4bfWQNrUolhDAHz GZMDWDTbK6OYmr0L9AjboyxoBgA6JSDydRqHAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2Ncw27BVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zk vpDh7+XSRYQZqjBiegbWAZjVCVfMvgTkFPHCSDXXc276WTjKiOp5so0SUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7HNaaG/uiCdxwhV/cguhnG/rEa tVfQj1odBnaODVEO0sNCYJ4l+Ct7pX6W2MJ9g/P9fZqi4TV5FFrzYHdc/WIQPzJH/9PpnbIo 32dr12sV3n2M/Tak1Jp6EmEhOXCgCf6U4I6D6Cj+7hhh1j77nweDlgaWEW2pdG9i1WiQJRPJ koM4C0soKMuskuxQbHAswaQpXeFulsZRIBWGuhjsAWVkPOMvUCeG3QOSSNHZJo+rsgqSDc21 1iP2dT0GThot77TQnWYnluJkQ6P1eEuBTdqTUc5ocEtubEPfKlbYsrzc+te
- Ironport-hdrordr: A9a23:6dThqq9fRvjcoGThHMNuk+GBdr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFrbX5To3SJjUO31HYY72KjLGSjgEIfheTygcz79 YGT0ETMrzN5B1B/L7HCWqDYpgdKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1cjegIK5Y1n3X nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3bRY0eTFcZcso+5zXQISdKUmREXeR 730lEd1vFImjbsl6eO0ELQMkfboW4TAjTZuCKlaDPY0LDErXQBeot8bMtiA2XkAwBLhqAC7I tbm22erJZZFhXGgWD04MXJTQhjkg6urWMlivN7tQ0WbWIyUs4mkWUkxjIdLH7AJlOJ1Kk3VO 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgEy82IIgMgE2nsQ/pM0TJdJo+ zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBNB1vd75rspLkl7uCjf5IFiJM0hZ TaSVtd8XU/fkr/YPf+q6GjMiq9NFlVcQ6duv22vaIJy4EUbICbQhGrWRQpj9aqpekZD4nSR+ uzUagmdsPeEQ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYVZkIemPHAQupqUK7B7t6KIAc2Kz6iS6AgAAJQoA=
- Thread-topic: [PATCH] xen/build: Fix MAP rule when called in isolation
On 21/04/2022 17:09, Jan Beulich wrote:
> On 21.04.2022 18:00, Andrew Cooper wrote:
>> Now that `make MAP` might rebuild $(TARGET), it needs removing from
>> no-dot-config-targets.
> Which raises the question whether the MAP target originally was
> meant to be used only on an already built tree, which would
> explain the missing dependency that you added in the earlier
> commit.
I can't comment on the previous expectation, but the fact you couldn't
previously do `make -j4 build MAP` was simply broken.
There are also several other breakages in Xen's build system which it
turns out is forcing all downstreams to bodge around in ways that range
from gross to dangerous, and which need fixing for everyone's benefit.
(Emails will be appearing for those shortly)
The current debug target (just runs objdump -d) is similar to MAP,
except I don't find it a credible target to use and was planning to
delete it.
>> Otherwise the build eventually fails with:
>>
>> CPP arch/x86/asm-macros.i
>> arch/x86/asm-macros.c:1:10: fatal error: asm/asm-defns.h: No such file or
>> directory
>> 1 | #include <asm/asm-defns.h>
>> | ^~~~~~~~~~~~~~~~~
> Why would this be? asm/ isn't a symlink anymore, so should always
> exist. I would have expected an error about .config or
> autoconf.h not existing, ...
>
>> Fixes: e1e72198213b ("xen/build: Fix dependency for the MAP rule")
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> ---
>> CC: Jan Beulich <JBeulich@xxxxxxxx>
>> CC: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>>
>> Backporting notes. The original, e1e72198213b, wants backporting as far as
>> we
>> can go. This patch is only relevant from 6c122d3984a5e onwards, so 4.14,
>> which is why my main developing/testing on 4.13 didn't spot it.
> ... and the commit you reference seems to support that expectation.
I haven't spent very long investigating exactly how it breaks. I don't
think it's important, because the purpose of no-dot-config-targets is to
skip large swathes of the logic.
~Andrew
|
