[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xsm/flask: code style formatting
- To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Fri, 22 Apr 2022 23:07:27 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sbxOhCfN9nkn/L+LnqC1edIGhfUPvHS5KTv1L7nfA7E=; b=DpYrBdJkOzrwgq0rtZajwUnQew6yPXfshQboHFeZgfyjox2i4jc1whNUSXxbI0ZKInn2vka+1RVzPHItbWrNemg3EGmX2AKGutPdtZBn6BuOig5yPBADzk7Qv7k8aUq3TPH915ZmQinXYnT83/Y82zm+Rt9gPsoGj+Uuph3odYT91m0klsq7PM8URLdqNnUygY2q4bqxTkuxkMBLJPGXpl+lQpASP7vVO45nA7j9BQRFEIWNGgD+PP7BP2yUv2el2aA/LbTwRupE8a6J2Zn3QOl/thgaWCn25FAvpbpEH758QU63p8xPO/UTJLq+tq8SW87LvF8hX4P8Xy4r18pxFA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fKM0VQ7W9oBIzdQsPQRbLxA6/PPQ8JbM+5c+dvXIBw8n1eVQzNg6Wr/kVzVxeE3aP1grHt2xfiFWmWMO5DZffBiyOY09ZNtI9BC1A1a82Pdv1fbRjZVsvglQr1mE65drXmcaWzoCE4pUzQq5Ho6Agqp4C/CJDCF7sPlZMgRaB04HQpmMtmznY4L9V0OuZ5a5lY6F/hyc7hYgL65aW/yTgbSDvV8znZdJXW3nLR0Al0Mrq/9ynlKWz7tUOHbN2piZzAYev6i5ygfID3ghBT3yxNFYfK5Yr3BDF01RYKPxfsxFf/rT2dDIVgqJFvq7W3/BFl7XR7CKSGh9hijOdNURAA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "jandryuk@xxxxxxxxx" <jandryuk@xxxxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
- Delivery-date: Fri, 22 Apr 2022 23:07:52 +0000
- Ironport-data: A9a23:t+kDIaC3zDg+oxVW/wziw5YqxClBgxIJ4kV8jS/XYbTApD123jEAy DdODWqOPP/eZGOme4wgO46/80lT7ZHXxoc2QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Jj2NYy6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPh+8 4tTuY3gdD52M7/SpL80EAl7SgxXaPguFL/veRBTsOS15mifKj7A5qsrC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t5B8mcGs0m5vcBtNs0rulIEezTe Iwybj13YQ6bSxZOJk0WGNQ1m+LAanzXLWwG8g7L+vZfD277lQMpz4e3APrsQ/eVZchpgFzHn VPkxjGsav0dHJnFodafyVqgnvTKnD/7cIsKGaek6+Vxh1mO2m0UDgZQXly+ydGph0j7V99BJ kg8/is1sbN05EGtVsP6XRCzvDiDpBF0c9hZFeEg+RyO4qXR6gedQGMDS1ZpZNMqucAsTBQ2x 1SJmJXvHjUpv7qLIU9x7Z+RpDK2fCQQc2kLYHZdSRNfuoa65oYukhjIU9BvVravicH4Ei3xx DbMqzUig7IUjogA0KDTEU37vg9Ab6PhFmYdjjg7lEr7hu+lTOZJv7CV1GU=
- Ironport-hdrordr: A9a23:RzvOGq2U1DYacpnHZ0kwOAqjBetxeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hcAV7QZnidhILOFvAs0WKC+UysJ8SazIJgPM hbAs9D4bHLbGSSyPyKmDVQcOxQjuVvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSwUBHQQb5A6Hii7twKLmEjCDty1uEw9n8PMHyy zoggb57qKsv7WQ0RnHzVLe6JxQhZ/I1sZDPsqRkcIYQw+cyTpAJb4RGYFqjgpF5N1H22xa1+ UkZC1Qefib3kmhO11dZyGdgjUIngxes0MKgmXo/EcL6faJOA7STfAxxL6xOyGplXbJ9rtHod 129nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMMjgZJq3PoiFXluYd499ePBmfIaOf grCNuZ6OddcFucYXyctm5zwMa0VnB2GhudWEANtsGczjATxRlCvgEl7d1amm1F+IM2SpFC6e iBOqN0lKtWRstTaa5mHu8OTca+F2SISxPRN2CZJ0jhCcg8Sjnwgo+y5K9w6PCheZQOwpd3kJ PdUElAvWp3YE7qAd3m5uw9zvkMehTIYd3A8LAv23EigMyMeFPCC1zxdHk+1829vv4YHsrXH/ 6uJZM+OY6XEVfT
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYVoFX0AAXIBUsy0WDoXcUztv2Zqz8jnWA
- Thread-topic: [PATCH] xsm/flask: code style formatting
On 22/04/2022 20:43, Daniel P. Smith wrote:
> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
> index 0bf63ffa84..e2ebbc7716 100644
> --- a/xen/xsm/flask/hooks.c
> +++ b/xen/xsm/flask/hooks.c
> @@ -120,8 +121,8 @@ static int get_irq_sid(int irq, u32 *sid, struct
> avc_audit_data *ad)
> struct irq_desc *desc = irq_to_desc(irq);
> if ( desc->msi_desc && desc->msi_desc->dev ) {
> struct pci_dev *dev = desc->msi_desc->dev;
> - u32 sbdf = (dev->seg << 16) | (dev->bus << 8) | dev->devfn;
> - if (ad) {
> + uint32_t sbdf = (dev->seg << 16) | (dev->bus << 8) | dev->devfn;
> + if ( ad ) {
Brace on newline, and in the subsequent hunk. Can be fixed on commit.
Otherwise, LGTM. Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
