[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH] xsm/flask: code style formatting
On Fri, Apr 22, 2022 at 7:07 PM Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx> wrote: > > On 22/04/2022 20:43, Daniel P. Smith wrote: > > diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c > > index 0bf63ffa84..e2ebbc7716 100644 > > --- a/xen/xsm/flask/hooks.c > > +++ b/xen/xsm/flask/hooks.c > > @@ -120,8 +121,8 @@ static int get_irq_sid(int irq, u32 *sid, struct > > avc_audit_data *ad) > > struct irq_desc *desc = irq_to_desc(irq); > > if ( desc->msi_desc && desc->msi_desc->dev ) { > > struct pci_dev *dev = desc->msi_desc->dev; > > - u32 sbdf = (dev->seg << 16) | (dev->bus << 8) | dev->devfn; > > - if (ad) { > > + uint32_t sbdf = (dev->seg << 16) | (dev->bus << 8) | > > dev->devfn; > > + if ( ad ) { > > Brace on newline, and in the subsequent hunk. Can be fixed on commit. > > Otherwise, LGTM. Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Reviewed-by: Jason Andryuk <jandryuk@xxxxxxxxx>
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |