[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/2] xsm: create idle domain privileged and demote after setup
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 25 Apr 2022 12:53:02 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GWlv0Hwx6m3KHUiLAt+bvdpKPj6a6h2mjmmvKM6k8sM=; b=e7a0PW6hnVgqlG1D/d7MPxKA9z3sOlO1T0LKfKFgLp2R2F+Lv2K3kZsVCCGZLtL2Wo5vIqzBWSMc69eDl6+LuH9ol864PC53x/baVFPjGowiZ6/Vu27OGza2Tsub6qxmyEktYXlQbpn/syB+abHStWI7O3XfFURzHktEVzN+jhGw5XooyXshyLHj/mCcCsjOSXln66lIFCFDhXSSkJPXa2iQrGVh3sompcETFf9kKT11OP4TlqDpxoMOoY7f6Onsqh6DKHEqUCiivBqliwDte4Fd1OYFdVZhNpFkigLKLaH/gV8MSf4MeK01J/wDXomM3pDsqd8v73lO7FuMQ4S9KA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SGOd2w1/9yRf0b1siVodxQXJikefAkVFmU/tTSHikwnvWG1CmDTfBnOxLRf2z1Cra6Q+LLgCO9RvjypPe+3t5+fOu9Gmt8CaA1/YPpwarQRe/lJA+CRs9rncKIsL03cQXZpy7h9LyDQb7xUrRpoxwxqvVQGwqsoQ2gXvMgcWdP81byoVjHUyhDkcpBpAT/4ZwIxKdQEh25F27YYXxPHq/wdNyHNRUsy0FXfpt67hKsRKeT3q0h68fWnKHcCodaxedotpo2On9qgtTRUvQVjPf6DqDFFsc7aj3bgr6NYyLPGYW3WRh2nD3ThwD6643JRvHdlpdvjr6nTv3bXkEnkMnQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, scott.davis@xxxxxxxxxx, jandryuk@xxxxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
- Delivery-date: Mon, 25 Apr 2022 10:53:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.04.2022 11:44, Roger Pau Monné wrote:
> On Fri, Apr 22, 2022 at 12:34:57PM -0400, Daniel P. Smith wrote:
>> --- a/xen/arch/x86/setup.c
>> +++ b/xen/arch/x86/setup.c
>> @@ -621,6 +621,9 @@ static void noreturn init_done(void)
>> void *va;
>> unsigned long start, end;
>>
>> + if ( xsm_set_system_active() != 0)
> ^ extra space.
Hmm, did you mean
^ missing space
?
>> --- a/xen/common/sched/core.c
>> +++ b/xen/common/sched/core.c
>> @@ -3021,7 +3021,12 @@ void __init scheduler_init(void)
>> sched_ratelimit_us = SCHED_DEFAULT_RATELIMIT_US;
>> }
>>
>> - idle_domain = domain_create(DOMID_IDLE, NULL, 0);
>> + /*
>> + * idle dom is created privileged to ensure unrestricted access during
>> + * setup and will be demoted by xsm_transition_running when setup is
>
> s/xsm_transition_running/xsm_set_system_active/
>
>> + * complete
>
> Nit: missing full stop according to CODING_STYLE.
Not really: A single-sentence comment may omit the full stop (while
personally I agree a stop would better be there). Instead starting
with a capital letter is mandated.
Jan
|
