[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 1/2] xsm: create idle domain privileged and demote after setup


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Mon, 25 Apr 2022 13:30:58 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p/ZO9v9R/w1tir+v/kYfqsH6oY0f/06Vjrne7HI0cQY=; b=Eh1q9S7NdVSJj0eU0EtFefKkyzx5nQmYwaWge79Hq5/8d/LLI+1ETlBZT3x16k2i33YkbXhzh+pif72mAjQDbi3w0393GeGaia+v0armq0glNFzENY/ogjdfKen33phhAfMaEx8NAShP1cfXJh5zrYJLGgT/1TD2mhFllo03NNhMhquBc1ytbdcXS0GCWG05mo6SeSEBGywu+62bQXuDA9qUJFPmvk8N8L2KvQx0w4o2D1j2fCn1vq47fo03iBUQyDNx029k7nwr8FTu/KFa3gg5SbiQJG2mIND/VlNMfXbQbF170wvzz9oKE8c1CxmUKAOhTi5ti0f3kodOQJgOIQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UwwFCLoBCqwC/HkUrlWftO4wY3KjWKb9maPIWrzSWkDgJSd74quKILDHuVigbUKHb0c/P04Rw6MyExzN3H4K9JaXfaunkjxLdgpvfMZ6TaUsiupto3p7n8HEnyLxpmLAxRVTHZamfymz8o+oHBCq5n+67SvmQMHevlbByg64hYRBzCeJDZsT7ZTlWA7Pn/a8ViEpqQ8PFp9JYvpLnUsHdeEUhjwpnjNmIAVAawPuB8LATKP2+F7i6pHfaAkTIyw6+vPw+AGWxHnDpr6PTitvNaoHkG6AJDOj0RlUOCqqa5YxoX+NMxUU8APD22P98u7NWEwsmyEA4Ebgya3qwT0NJg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, scott.davis@xxxxxxxxxx, jandryuk@xxxxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
  • Delivery-date: Mon, 25 Apr 2022 11:31:13 +0000
  • Ironport-data: A9a23:vej8sKO2cqP5AIDvrR3kl8FynXyQoLVcMsEvi/4bfWQNrUpx1jIDn 2pJDWCGP/2PYzfzKdh+aoiy9UgC6JKByYVhQQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2NMw2LBVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z1 fkOjo26FhwVIY7UxcZEUAcbOgtuIvgTkFPHCSDXXc276WTjKiGp79AwSUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7ENaaHPiiCdxwhV/cguhUGvnTf YwBYCdHZxXceRxffFwQDfrSmc/33iOiKWMH+Tp5o4IH82vMxQ8hjYLwH4DbdMC4ROB2pUuX8 zeuE2PRR0ty2Mak4TiP/2+oh+TPtTjmQ49UH7q9ntZmmEaWx3ATIBQOWEGnvOKijUqjR9NYL VdS8S0rxYAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxLlYDSjlNedk3rvgcTDYh1 kKKt97xDDkpu7qQIVqC8p+EoDX0PjIaRUcZbigYUU0J6sfiu6kokhvVSt9pVq+y5vX3EDf82 SGXrwAxgrwSiYgA0KDT1Uvcnzumq5zNTwg0zgbaRGSo6kV+foHNT4617VnW695QIYDfSUOO1 FAOltKC9ukIAdeInTaUXeQWNLiz4rCONzi0qVJhFpYu9jOp+la4YJtdpjp5IS9BPskIdDDza WfPqAhR49lVJ3LsYqhpC79dEOwvxKnkUNjgCPbda4MUZoArLVDauiZzeUSXwmbh1lA2lr0yM ouadsDqCmsGDaNgz3y9QOJ1PaIX+x3SDFj7HfjTpylLG5LHDJJJYd/p6GezU90=
  • Ironport-hdrordr: A9a23:dSzWTKGLFrXPxsD2pLqFepHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LW90Y27MAvhHPlOkPIs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79 YbT0EcMqyOMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPH1XgspbnmNE42igYy9LrF4sP+tFKH PQ3LsPmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZUbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczLgBkF5MWUrHo6mt jFpBkte+x19nPqZ2mw5SDg3gHxuQxen0PK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tps+CVQpAZEyHsHceg02w 31CNUXqFhwdL5nUUtcPpZ3fSLlMB26ffrzWFjiUmjPJeUgB0/njaLRzfEc2NyKEaZ4vqfa3q 6xGm9liQ==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Apr 25, 2022 at 12:53:02PM +0200, Jan Beulich wrote:
> On 25.04.2022 11:44, Roger Pau Monné wrote:
> > On Fri, Apr 22, 2022 at 12:34:57PM -0400, Daniel P. Smith wrote:
> >> --- a/xen/arch/x86/setup.c
> >> +++ b/xen/arch/x86/setup.c
> >> @@ -621,6 +621,9 @@ static void noreturn init_done(void)
> >>      void *va;
> >>      unsigned long start, end;
> >>  
> >> +    if ( xsm_set_system_active() != 0)
> >            ^ extra space.
> 
> Hmm, did you mean
> 
>                                          ^ missing space
> ?

Indeed.  I was switching from a different code context and got
confused.

> >> --- a/xen/common/sched/core.c
> >> +++ b/xen/common/sched/core.c
> >> @@ -3021,7 +3021,12 @@ void __init scheduler_init(void)
> >>          sched_ratelimit_us = SCHED_DEFAULT_RATELIMIT_US;
> >>      }
> >>  
> >> -    idle_domain = domain_create(DOMID_IDLE, NULL, 0);
> >> +    /*
> >> +     * idle dom is created privileged to ensure unrestricted access during
> >> +     * setup and will be demoted by xsm_transition_running when setup is
> > 
> > s/xsm_transition_running/xsm_set_system_active/
> > 
> >> +     * complete
> > 
> > Nit: missing full stop according to CODING_STYLE.
> 
> Not really: A single-sentence comment may omit the full stop (while
> personally I agree a stop would better be there). Instead starting
> with a capital letter is mandated. 

Right, it's a multi line comment but single sentence, and hence the
full stop is not mandatory. Sorry for the noise.

Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.