[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 2/6] xen: do not merge reserved pages in free_heap_pages()


  • To: Penny Zheng <Penny.Zheng@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 4 May 2022 15:29:44 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y9+FwQel3xlzm+ts3VujKHKpahUBSQESjXCgj5tGyjk=; b=A7Dm754bpMUrhAUMmSgq49nYUD81gu/LEKUCEbMBrM8yiyTI8J9irEZB8SDPdqbdAUxUct3FM+FApCcbh9lH32kFwbgVstEdoRUziSfHQBYdJErHOh8iezR+/iYM4oSZbhbgNi4ClSWk5mxv62PoRmnWiLHygWadyxJJkkePMuEBDeNKSCC4Jzdc/aAihMX+V7i6G3amPMPMMpIRuV0Pz7qoni3VRxO/F2vsT+J2PO4GPsfw09qJuhDGboclERnTpbqX9NhTULE+vQkKn+VIr6/7sNSjIFanY8Gh6tDFJKrCLgOenx2R4eaO1O86gdQtBRoDIKVaoBUyc58bmOgiFA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gpy2r+MDovDcNjM4ebaY+UqmzIWP6WKCNvgChU3gkjOIK6cPB2qA0PMgprKCo/J9cvuM+D2ZHueKTAwBJ4IGXbIZGDEaVREYzyeP7x/cx10hf5xMXt9LT9MVbezBzR6jMevnPqO7Ue2tSuCJttEZbv0v1keG1pqXgXhBQ9U8MinHOphyrQvPkpssWcaZ0Uz3wWVhYzt/6U+NZsDuiewPkI2Mu3NJDX2n5RwTMW+2n1FwV4sSVBmqqAX/SqjgsPiO9ifm1oFH5WyhyAcnN8pRqxuOrL7CgR/1Ck0pfJ86xhsNf0VTAyfRajO5fRTYTVUE9D7SHOgFOsZhZROeNvNYeQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: wei.chen@xxxxxxx, henry.wang@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 04 May 2022 13:29:54 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 27.04.2022 11:27, Penny Zheng wrote:
> There is a slim chance that free_heap_pages() may decide to merge a chunk
> from the static region(PGC_reserved) with the about-to-be-free chunk.
> 
> So in order to avoid the above scenario, this commit updates free_heap_pages()
> to check whether the predecessor and/or successor has PGC_reserved set,
> when trying to merge the about-to-be-freed chunk with the predecessor
> and/or successor.
> 
> Signed-off-by: Penny Zheng <penny.zheng@xxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

I think this also wants a Suggested-by or Reported-by (iirc) Julien?

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.