[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v3 2/6] xen: do not merge reserved pages in free_heap_pages()
- To: Jan Beulich <jbeulich@xxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>
- From: Penny Zheng <Penny.Zheng@xxxxxxx>
- Date: Thu, 5 May 2022 05:51:54 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YTk4w4kM8VASug7minekMuaUJ+KOdkYv7klB2qI+Y7Y=; b=Cft3Lm2u1FaDg1g9RXFW+oRypfszYWxubrBRNeEobGP7ITManMGA/Sc7+l9SxPYTcFc6UH39wZPCOKzpEYzNN171+Y6EZuIQSkOf/ZVyyeMhkxS1X2gkwjci/2wJeEbY7j4o/Sw3xOdM9Yo2y3T0jrQ4Nz5NWGNudmpfAnLT1HhFro6BrzXgcW7GgimPdIPhPcRe/c+fRAVz/yPPIYBlIKnP0/l0Vih1R6ivXCwz087YNvID5s1hM/txZhvEPIYBnklyXXcBFJ4TzdgJEdq/p72QTxsEUwGB183lEMyXsGqtnkrdx+JFMqeIqjEDUFenV9JvOZNgaTzWa6GQkI1BfQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YTk4w4kM8VASug7minekMuaUJ+KOdkYv7klB2qI+Y7Y=; b=k1yvBRgmw0A+F3pTxkKbA8eCqQ5Drt2YY/+Cidk3Q3qJ6lfbM5ma8Df5wOPyT0AJJdPN8NCWA69DmYqxQpJzufVS5zkpwqe7kjk71M/EmjOZ5/VupjPwf9ElsNmvOpiXSWUGnfgp7S16L73DqX3w6J57GKy+/A9xIVWXEMYKB3kPEp4jsneOOvbmQXKbPOZ7ya+KUw/5uFC3thVQGexaQYViaMlLoPXI/kZHAol2JN9i8TC/Ss7nxlWG+p98f1Dtw0KttI/VpQHn7Xi0Rm9I6p0V0aIC6eJLZ7YX6ztwBPeEQtp7ebuh5YVLXRS7tyN1GtY81qo+xdmScji53m7wNQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=SulS33LZtyKfpIrRkieYc6vMscbWcr/VlX6Rntamyuqd+htQ66GRXmYq1kOfICskc8I7oGW55Aphkn8IQkRgAojU2rgSzJ2/NemiDKGRcQa/hNTWw1/Q4cyfrimr1tAaF8AOgt7AzQr1bbg8+npppGbg2Ll98SzlvXyVNwxys3Rmxap+7SlYVl9P01CYmS43578NIjgrhOQsCnfchMx5vMtgvL804THu0VA+fIPMWTuF6On/olEqZR1lQKKSzNQhJTsGGthL0pjskspDSaq0/jreZ/PBHzR1Lm9xjJntR0K3/DRw6XL/p1jTaGGZN+cYxN5CbA8XuJ8tl3V6eya9Pg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JfPkMwizstMZwulyEDC9TmK4Oh7naJ89naLZBG9z2F+Y5+gCUJ6WS9NN1hcDe8HHa3vQF6cZMi9AeyFMvvdwjWL2tq7IBrJXzCehPSOqFUc+3x3S2kmvKdBd+hAEnEj5HgHduyL2an3Zzhr+bcg/fkjrCfCiIfnBHAq90k89kyEdRqHHYpKyMF+qN9Y4gQeH7Cyrep6YtjtHZjJkVD19GZicevOBc025hVLxvcHanF7QCZlLzA6yDGBQetOV5hAHdjd6vPoTczvU0juGsW0PATDqnMFCcde8A2gi9/rj1GLaQDIvfUV+eZAvGgPzY+2sizXkLTLW5iglcyNM97B/Qw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Wei Chen <Wei.Chen@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 05 May 2022 05:52:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYWhkw7aZ3ZAXjYkKl+baB+o3PAa0OwdUAgAENzPA=
- Thread-topic: [PATCH v3 2/6] xen: do not merge reserved pages in free_heap_pages()
Hi,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Wednesday, May 4, 2022 9:30 PM
> To: Penny Zheng <Penny.Zheng@xxxxxxx>
> Cc: Wei Chen <Wei.Chen@xxxxxxx>; Henry Wang <Henry.Wang@xxxxxxx>;
> Andrew Cooper <andrew.cooper3@xxxxxxxxxx>; George Dunlap
> <george.dunlap@xxxxxxxxxx>; Julien Grall <julien@xxxxxxx>; Stefano
> Stabellini <sstabellini@xxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3 2/6] xen: do not merge reserved pages in
> free_heap_pages()
>
> On 27.04.2022 11:27, Penny Zheng wrote:
> > There is a slim chance that free_heap_pages() may decide to merge a
> > chunk from the static region(PGC_reserved) with the about-to-be-free
> chunk.
> >
> > So in order to avoid the above scenario, this commit updates
> > free_heap_pages() to check whether the predecessor and/or successor
> > has PGC_reserved set, when trying to merge the about-to-be-freed chunk
> > with the predecessor and/or successor.
> >
> > Signed-off-by: Penny Zheng <penny.zheng@xxxxxxx>
>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> I think this also wants a Suggested-by or Reported-by (iirc) Julien?
>
Sure, I'll definitely add-in Suggested-by: Julien Grall <jgrall@xxxxxxxxxx>
> Jan
|
