[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules


  • To: Julien Grall <julien@xxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Tue, 10 May 2022 11:52:38 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zr980hwglPXKbEtBZQOr5MfKE8T8o2fCZSx9I06tq3U=; b=O5oO3dze7tS/Tjj1itsa1kMcLGrEt7oHzFuT1Wnp/K05RxK+Bdb6u++FUwtofaVQ1nWQednd0HiiBGHWz9wmr1nU41flmIrrpVGiyYLAWmihr/mFymUPfLkkRydsMQw22DRtH3FEaBWJB4nqHmRyz6+pbelVxQ2t0YgDN778kNgN3ZnNi3aHV3IG6CR70+dz8VctKlr2x3IQoXCKa92Mnounw/MY0ikJLI11L6McWMiuuX2TOstroteheJY3b0bc/uD+paY530emEoghr11PXOB0ngEx4BKvK+xmy3b6B9dxyAHWgHI0E1pciedQ3Y0Y50O1G+j74rmN8K249qwTIg==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zr980hwglPXKbEtBZQOr5MfKE8T8o2fCZSx9I06tq3U=; b=NyPH4ccZ3RheP9QblWpgusc3OJf6Nyb8XStw+VGaAfV23lL/JVbhIyhhplBc77ZYHAiIBjmdJYQWMZkgLwSh97h0Qq3CrtLN8ZhVwyK/I6fr4xNV6GzLwaNxRp1B/gzeLZBaiXjmyrNDPnDqK1qjz/sXnSVTzXGq8O8e5yCkufzr4vuY3H1EPQ8GZPZuC/gTtWQoTStKRAsYD2BxvWVeOkuVfVtd3lL1VbMXGVA3u6M+jEw0xFu/BNmfT0+qojgnZQrAi8affLFTIQpUiCN8vnaoqmQhGD9Kck96+lmIiJaNWquRz/GItqrnha2FcsO+tsS0y7WAeZjDLdnJ+eLXLg==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=QH00rNmOEp01+rpMk/gHuGg7MVBtVV0EdBTetPdpyaGosYRNk3zMNl+OvP0709MN4Yg41RgcVQcbZCRANCaehQyAwh327tZg7zliNpm+WFwEJ1H0whoBY0vB0jewH+7EimGp09+a8URk4pB0pfeiI4z5Xgnea9lE6quJj+rNXedFsIHgzpP8SdOIle7u8vsBt62mVO2YRsf4C36Krr+kxgE21Bb1FSvRp6/HHn6RMipaUnXryUa/8biSFmG8a+FL3xu0HmXZ58NwnhItgEDKpmccpfngZosGBJksp2Q7ubGZbB4EPpwMAOI5qaMmQTeys8lz/yyuOJ8ruc7R21jNIw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LmnpdxflorWsXQnquQMOqgrt1jJp+sUxAwwiaJQ3FDR1hbOb2Ej+H+CGzAl02hK8Cli8cS5P3Dy1AKrdLGS+gFhRb5wDJ5L6hqSNjRawNU8e1bHojZ0Ray9hVcFwzDXR3tSJgPcQ/wcTcsR0hIPPzLkFMl3gp8aX/6JiTUOlMmpd5j81Cdtin3cbq9OMC4XOtYL9TbjzRohaE7kOZgJQyvgIPlvPypoiQZAeucyearc8Y5cc4WBQxAlFPHhxcBRUZag/Uidj/wMfSWrQ7sQ2/3MgSlxL113Jb+dI0ZO7/AoEhyKWGrr8V+xhoziDd5OUg1h4da5MwmfZFjVOOs//IQ==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Michal Orzel <Michal.Orzel@xxxxxxx>
  • Delivery-date: Tue, 10 May 2022 11:53:02 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHYWWqn4igAeGv7Uk6q5mD33SrErq0W8JQAgAEkhwCAAAB3AIAAAHwA
  • Thread-topic: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules

Hi Julien,

> On 10 May 2022, at 12:50, Julien Grall <julien@xxxxxxx> wrote:
> 
> 
> 
> On 10/05/2022 12:49, Bertrand Marquis wrote:
>> Hi
> 
> Hi Bertrand,
> 
>>> On 9 May 2022, at 19:22, Julien Grall <julien@xxxxxxx> wrote:
>>> 
>>> Hi,
>>> 
>>> On 26/04/2022 13:38, Bertrand Marquis wrote:
>>>> diff --git a/xen/arch/arm/include/asm/processor.h 
>>>> b/xen/arch/arm/include/asm/processor.h
>>>> index 852b5f3c24..ef37cfa16f 100644
>>>> --- a/xen/arch/arm/include/asm/processor.h
>>>> +++ b/xen/arch/arm/include/asm/processor.h
>>>> @@ -219,9 +219,11 @@
>>>> SCTLR_Axx_ELx_A | SCTLR_Axx_ELx_C |\
>>>> SCTLR_Axx_ELx_WXN | SCTLR_Axx_ELx_EE)
>>>> +#ifndef CPPCHECK
>>> 
>>> Can you add a comment explaining why you need this check?
>> Sure, would the following be ok ?
>> Cppcheck preprocessor is wrongly throwing the error here so disable this 
>> check for cppcheck runs
> 
> That's fine with me. I think my ack is technically sufficient here and 
> Stefano tested the patch.
> 
> So will do the modification and commit it in a bit.

Thanks a lot :-)

Cheers
Bertrand

> 
> Cheers,
> 
> -- 
> Julien Grall




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.