[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules



Hi Bertrand,

Since this patch has been committed, I get the following message for on every build (make -C xen):

which: no cppcheck in ([...])
/bin/sh: cppcheck: command not found

I wasn't expecting the build system to check every time. I think...

On 26/04/2022 13:38, Bertrand Marquis wrote:
+cppcheck-version:
+ifeq ($(shell which $(CPPCHECK)),)

... this is because ifeq is similar to pre-preprocessing. So it always get executed.

So far, the message is harmlesss (I can continue to build) but I think the check should really only happen when the target cppcheck-version is executed. So can you have a look to rework the rule?

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.