[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 20 May 2022 09:59:03 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9PW6L+UHr0I4Egz+Ef+UDCrUa3rCGJEm+zZMjtcVPBw=; b=MCUbN16Oo0r6DCn1bFDS6z6TPuptjwyIOWTI4IBbuPEuG4egzcnt1GejcoqKq1Gd38a+ckN0XRz9FsBRAWKp9d4sG4JQZnVInuzFOfVezZVXyFpoA1yAUfqMFsJO4iU6woJmOf0/FjbyLN4RZblVs2qpFotZgV3aZFp1s0Ph7rjg3WBiI0OSLIhkhkstu9D7/GyrE9ReIjLwxv9LiaGFaV/4shb4iel+viNWumZgfz49JhPT/6mlQmlZxPuxjszFT+IfOtSFNfROqNWDE2w25l01uv0/0WNWFVH+/fj6eRsCEPyhBoyTAjLQl8fPG0M0ANk3wVy/nPHzp+XvMOUfzw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9PW6L+UHr0I4Egz+Ef+UDCrUa3rCGJEm+zZMjtcVPBw=; b=hUdHQOyBn3eQooNRjwVdJl/aL8MODr7D0lSzpq+S6nbYM3v5Fsm8J1NTjgxq3/k44yFVvOf2zHmpGycNQpWNc8CWzv+Zr9Kf8lg5JV/jhyG1QJ6ndgUDM4hCoXbMq5O++5O6Uc+BGOdC8leCI5gGNUJv6dh6+UCAeEiTakS1vrZRMWwSbs3XrXPdNQJzAutIL2sO34wyrNaHLbgyTX8Lk3/DoEnP37qwPV6JcWMX/Q2uGkeROdeSvAfu2ZInUw4jYJmQYPJ1BYuB55mS9NZCWweegqBxlLIEoQd8HHILEoM3qMd4QJPFtynlFvWyifAq1vDmni0Z9SYhspq+36KBdg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=dfMqCYcKt4MJccWxSakV/MgMAn2CL8n+bLQPjsF4jgySUDgfKNkHHXQ5++42fGUviM1Yt+r6ugcEuB8JxUL/ahJNb5SGwU3PxlbpvBFmaTL8EbK8e53NKY1Om/AU/QMce5QdBjRP/JcmKXcsWbE57u9cactOq1WTF5G13jXnIbXCDcY4qbZGf5KlDkA+MQqajO5ObEKKDW3ZbFZsPav4uJkWhn3l7zkRu69tcHPhqssCmVl4u/NS9mef5/kml++edgOA8sAvsej8B1h2YRRLTjUOYhnNM7ls+H9og2I/QaFmNasS1fleUdijM5EHlCHieV+NRpnULnpJCRRTVZpcug==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MFZhVLWWqGp1GASt3GeGFX2RGyVy+MDrrmRv5Txe0Wv1YaO1RX+YJpj0plVja9xIgbLp6TxZCu0MEAFPE2rTYnCHk1/tzE9S4dKm8SF/ke903Y0wsaMWJ9xkHqRW8HX4GYuh0S89LBRCHE8gYlgZS7DUy8auP68Edu4FF31J8+4HQXplJTz583pba3HGN8N2CQuvEbeV+wwNQYAjT7hFWTEDlZ9VJeWnOtBFUF594XmHJsCEdPUSqMaRCzCg8EioiGflDqj8zpiOdpmo35P0a8JTUoIBpy+OOd0DnTNj8P4Qn1B/jSgsIHAJDldJg3W6jOFdsGEZTmPomFF2uMiJIg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Michal Orzel <Michal.Orzel@xxxxxxx>
- Delivery-date: Fri, 20 May 2022 09:59:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYWWqn4igAeGv7Uk6q5mD33SrErq0nrOiAgAAAuoA=
- Thread-topic: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules
Hi Julien,
> On 20 May 2022, at 10:56, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Bertrand,
>
> Since this patch has been committed, I get the following message for on every
> build (make -C xen):
>
> which: no cppcheck in ([...])
> /bin/sh: cppcheck: command not found
>
> I wasn't expecting the build system to check every time. I think...
>
> On 26/04/2022 13:38, Bertrand Marquis wrote:
>> +cppcheck-version:
>> +ifeq ($(shell which $(CPPCHECK)),)
>
> ... this is because ifeq is similar to pre-preprocessing. So it always get
> executed.
>
> So far, the message is harmlesss (I can continue to build) but I think the
> check should really only happen when the target cppcheck-version is executed.
> So can you have a look to rework the rule?
Sure I will push something to fix that.
Thanks for the notice
Cheers
Bertrand
>
> Cheers,
>
> --
> Julien Grall
>
|
