[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 1/2] xsm: create idle domain privileged and demote after setup
- To: Julien Grall <julien@xxxxxxx>, Luca Fancellu <Luca.Fancellu@xxxxxxx>
- From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Date: Wed, 11 May 2022 07:05:37 -0400
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652267206; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=9n/aS6rL2TlLAqR5rCBnVob92xkCeuTrUzwXok9Ctks=; b=by+2gTOE1eg0PsTupT+jukoWl7HczTMyNFcOAJ1bch4CiyMXgr69XEjaPTHEXNb8zWJFDoA+cBQ7/Du1HFM/MPbrOOgwwUloVFrLxT/DHSmrJZPaLIiv91uwaVrFktgy9yApjMPzpXo8tdG4dXTkRfeiaRPGWHuiv1vBoNlQj94=
- Arc-seal: i=1; a=rsa-sha256; t=1652267206; cv=none; d=zohomail.com; s=zohoarc; b=Lhb2nJ+kynrJR6BzzaA6jSc5Yoz7+1OTWG4TH1uSUcWP/6JlK5i7oXan4SnOK1TN6nXvGpEPjuoO9yiCN5YMWsPMnbXzJQ50XpOcOtTNh0/DtbSC0+3bz6K4P3buZGM4HaZSIXJ6sx59wpSRSMl69gka8hYOpYY99YvbX6A+lhQ=
- Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Scott Davis <scott.davis@xxxxxxxxxx>, "jandryuk@xxxxxxxxx" <jandryuk@xxxxxxxxx>, "christopher.clark@xxxxxxxxxx" <christopher.clark@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
- Delivery-date: Wed, 11 May 2022 11:06:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 5/9/22 14:33, Julien Grall wrote:
>
>
> On 03/05/2022 14:17, Luca Fancellu wrote:
>>> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
>>> index 0bf63ffa84..b93101191e 100644
>>> --- a/xen/xsm/flask/hooks.c
>>> +++ b/xen/xsm/flask/hooks.c
>>> @@ -186,6 +186,28 @@ static int cf_check
>>> flask_domain_alloc_security(struct domain *d)
>>> return 0;
>>> }
>>>
>>> +static int cf_check flask_set_system_active(void)
>>> +{
>>> + struct domain *d = current->domain;
>>> +
>>> + ASSERT(d->is_privileged);
>>> +
>>> + if ( d->domain_id != DOMID_IDLE )
>>> + {
>>> + printk("xsm_set_system_active should only be called by idle
>>> domain\n");
>>
>> Sorry I spotted that now, here in the printk probably you mean
>> “flask_set_system_active”
>> instead of “xsm_set_system_active”, you can keep my R-by after this
>> change.
>
> I tend to use "%s: ...", __func__ so the name always name the function.
Ack.
v/r,
dps
|
