[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Wed, 11 May 2022 14:35:05 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rJdxi7CrMvEhLOBOVcaSvEGwAoBAWypsoYAVt6Q+ipk=; b=B9Jf6xvwcjL8ub3SUnqyxQ3YBv3vfv9N4N+uXFZJNMt6ySAUAuG4gNe6QNhQdACgrKAXS3UtLfVuuDS00y2ELBiILQLEzrGG4DY81xJQOrHBUzhXzr31iut4sOu5gKmSx2H2DEI+3h04WUPBkEc7Gqj4PVC4WE9WOaYunNPAapr6qZ5VhyNHloQOpSjL9iaYGRtlAYQFYjR0aTZXH2OvnXAfvz3YLqARz6Y9T4lJToD7bPPjgHk3TJVef6BXcWSicnzV1lhM3f44Gff8GWJ7zWaP/8wY3xMP2XoLhN0uORY54cZcCrj8g6dwM0ClCmHUIvx+/Sidgm/O/h5KLXtWNQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oe1WjfQEyADumebeHtuUidJRUAQcJPLxPDkQai7OnqxVY/dKCcugOtayqIP6a25XDK3prL6M77PXr0l8+XRWbT6TOIM2jTkxKfAuAdQOSGu7/rAgUvDWhSMR1BONIh4gAuX0IPB25B5uL+dDpTTS+l0y79afXML3vzNFCfrxLcIvY+1IVzLC/ERvju6IZtCvKUQg/+AFB76yGkRfL21CBPmk/JP9BtpXix0Y7UHQAler+kUUNLe2R26NQsIOTqGVP1a01jrsrEt3vT+ddl8qVJOb0W3+SVft2HgaHKXYF+dfl4m/Q8qn7ww1fBsOC63HpL510ud3AQOBdrlANfVIZQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 11 May 2022 14:35:17 +0000
- Ironport-data: A9a23:R1h7lKg7W9/wjMmkTQ1zyaADX161WhEKZh0ujC45NGQN5FlHY01je htvCmDUbKvYMWrwf9BxPY61o08BvcTSzdJmT1Q5qig0Fygb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlrU4 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YRkEAPPWlesRaQsbHjpaH7RG0bziB0Hq5KR/z2WeG5ft69NHKRhveKc+qqNwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuI8ehWlh7ixNNa+2i 84xQDxjdhnfJTZIPU8aEskWl+a0nHjvNTZfrTp5oIJouzmPklEoi9ABNvLZY9ikFdQOmH+pp 1zc8WOmWg0jOt+mnG/tHnWEw7WncTnAcIcbDrix7PNpqFyV2G0ICRcSWEe7oP+2kUq3UZRUL El80jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcL84QyUG2wFRT5pc8E9uYk9QjlC/ l2Um9LkAxR/vbvTTmiSnp+Pti+7MyURKW4EZAcHQBED7t2lp5s85jrQSv5zHajzicf6cQwc2 BiPpSk6wr8V3cgC0vzi+Uid2mz94J/UUgQy+wPbGHq/6R90b5KkYIru7kXH6fFHL8CSSVzpU GU4pvVyJdsmVfml/BFhis1WdF11z55p6AHhvGM=
- Ironport-hdrordr: A9a23:De8HjKF3ysnM5DUXpLqFsZLXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNJICPoqTM2ftW7dySSVxeBZnMbfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj3Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnZ4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlXFtyssHfrWG1SYczHgNkHmpDp1L/sqq iLn/4UBbU315oWRBDtnfKi4Xi57N9k0Q6e9bbRuwqenSW+fkN6NyMJv/MmTvOSgXBQw+1Uwe ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjx0C3fLFuHoO5l7ZvtX+90a1wbh7S+cQiCq 1jHcvc7PFZfReTaG3YpHBmxJipUm4oFhmLT0AesojNugIm1kxR3g8d3ogSj30A/JUyR91N4P nFKL1hkPVLQtUNZaxwCe8dSY+8C3DLQxjLLGWOSG6XX50vKjbIsdr68b817OaldNgBy4Yzgo 3IVBdCuWs7ayvVeLqzNV1wg2TwqUmGLETQI5tllulEU5XHNcnWGDzGTkwymM29pPhaCtHHWp +ISedrP8M=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYZT9h/psFFcQ9ZUSTli2D9MFhrq0ZuLuAgAAFYoA=
- Thread-topic: [PATCH v4 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff
On 11/05/2022 15:15, Roger Pau Monné wrote:
> On Wed, May 11, 2022 at 03:59:28PM +0200, Marek Marczykowski-Górecki wrote:
>> Intel LPSS has INTERRUPT_LINE set to 0xff by default, that is declared
>> by the PCI Local Bus Specification Revision 3.0 (from 2004) as
>> "unknown"/"no connection". Fallback to poll mode in this case.
>> The 0xff handling is x86-specific, the surrounding code is guarded with
>> CONFIG_X86 anyway.
>>
>> Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
>> ---
>> Changes in v4:
>> - adjust log message, change it from WARNING to INFO
>> - re-add x86 reference in the commit message
>> Changes in v3:
>> - change back to checking 0xff explicitly
>> - adjust commit message, include spec reference
>> - change warning to match the above
>> Changes in v2:
>> - add log message
>> - extend commit message
>> - code style fix
>> ---
>> xen/drivers/char/ns16550.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c
>> index fb75cee4a13a..c0d65cff62fe 100644
>> --- a/xen/drivers/char/ns16550.c
>> +++ b/xen/drivers/char/ns16550.c
>> @@ -1238,6 +1238,13 @@ pci_uart_config(struct ns16550 *uart, bool_t
>> skip_amt, unsigned int idx)
>> pci_conf_read8(PCI_SBDF(0, b, d, f),
>> PCI_INTERRUPT_LINE) : 0;
>>
>> + if ( uart->irq == 0xff )
>> + uart->irq = 0;
>> + if ( !uart->irq )
>> + printk(XENLOG_INFO
>> + "ns16550: %pp no legacy IRQ %d, using poll
>> mode\n",
>> + &PCI_SBDF(0, b, d, f), uart->irq);
> There's no point in printing ->irq as it will be 0 or else the message
> won't be printed.
>
> With that fixed:
>
> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
TBH, can be fixed on commit, save another round of patching.
~Andrew
|
