[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 9/9] xen/x86: use INFO level for node's without memory log message
- To: Wei Chen <wei.chen@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 18 May 2022 15:33:57 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CdpQQLFkjDvga25tn09GfvRtH8pgjQVe+5EpXeAq6ns=; b=hA2AnHZwZyY4qZ7eu96DykuXigdLIj4uxMSrecUdzelJkHgdRLL344+1u4xx4W4dri2K5VZQXioaZYP+Jx9iRMSkvcpYn19v7DOPKE1s9RmfW5iMyhhg50UmnFyCMnGzhA7VMG51rXGVPOil9FsTFyqCXqkYof/OtKDZk5DyPbXXYyjcZ8PFbTzzVd+c59CGBmxYgTMwIetKC2hYAFh4FsD9oXucBg0QwIe/WTB/qYqFhI+LEhqcGvmeNY6MM+H28UGr+t35d2BEU0CZW7jiif+MFQZ24TkIyBNAIYQ7Go/WUbsz7JCcaur342F/QoLePYAxga1xD2aMKktu5THUUw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R8w2bLx14ID5+VUdv0JKDwBuIGB8eiXN6QfkdA/nxqh92u7L3aQtnlrGvqx3Z/Pa3BhGXxnh+SNqeV/43fThdip2ZHjoCR1aaCSExPre/1fbrVwrQNKL5DaeUqxKYW/uj8YobnV/FAc3ZDlHLhV9YcgT8GGwzSMeBOasj0B418Qt2W/FOjG6sNdd3Z1h5oay7gb2SAGr+4/Q8PF9Wpqwn8RUMjATNkY5gy5+7E4zJxdmEA7szMCVe41gwWUOVc2Aocj0aHnLzjV4dudLtM2WJnl6zagVMi7qwSotYa965tYmbf6njLC1F0DqbN4Mvne13h2jHk8Era0RTYD2eOC7Eg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: nd@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 18 May 2022 13:34:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11.05.2022 03:46, Wei Chen wrote:
> In previous code, Xen was using KERN_WARNING for log message
> when Xen found a node without memory. Xen will print this
> warning message, and said that this may be an BIOS Bug or
> mis-configured hardware. But actually, this warning is bogus,
> because in an NUMA setting, nodes can only have processors,
> and with 0 bytes memory. So it is unreasonable to warn about
> BIOS or hardware corruption based on the detection of node
> with 0 bytes memory.
>
> So in this patch, we remove the warning messages, but just
> keep an info message to info users that there is one or more
> nodes with 0 bytes memory in the system.
>
> Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
preferably with ...
> --- a/xen/arch/x86/srat.c
> +++ b/xen/arch/x86/srat.c
> @@ -549,8 +549,7 @@ int __init acpi_scan_nodes(paddr_t start, paddr_t end)
> uint64_t size = nodes[i].end - nodes[i].start;
>
> if ( size == 0 )
> - printk(KERN_WARNING "SRAT: Node %u has no memory. "
> - "BIOS Bug or mis-configured hardware?\n", i);
> + printk(KERN_INFO "SRAT: Node %u has no memory.\n", i);
... the full stop also dropped (and maybe the upper-case N converted to
lower-case).
Jan
|
