[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v3 9/9] xen/x86: use INFO level for node's without memory log message
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Thu, 19 May 2022 02:37:19 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E0VtX9O6STDiYkp7saiUV02SApI8T6q3B2TRx1qsQx8=; b=TyGuRnf8NOaE9t2IL1b9OdlWGnS68q/rrvCoiwWzZyWc5tEVxLMzWkN7XxKsDaB5J48xwIrOOkQ+hNthDBTYZlV50q5KPf/u0RSVQvX9plFLk8I+ZoJNU6xW6mKBOregMgJQ0RLLY1bZIXdVhD+JI/r0zYRErM9EBgBddYFCLAmkhr0QmFxTok3Wp4HfvxX5wz8CW6kw5TQDyqAHWol/itaYDReAjvi6oO/q2nX3TGBn0bEvGQh8xlhy3cLlA1vPlgSqEA0f7OhEkEj5zigK7mg/2D/9Vpa9gatELa3HU88MgR7KHoXuYnp/jW5QQLLJfdUL2SN5GYGR6ZTVl92dUg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E0VtX9O6STDiYkp7saiUV02SApI8T6q3B2TRx1qsQx8=; b=JaTiMfEMW70WKuA7Kn4eG3IzwN25NgDZ15vbnnTj/DkQMSlQQtI+JkwWcDJmcGgAY+G/J9Z9/mA6RKXsTDXV9CRemdtZmiv11/GvV+LcMFjzlYNwXy9pu6d1dJlPPy8fjubbI4e3e6+j6g2jqyN+uQyyCnCxiYrzSRGgpZO6VwmZohPZbjB1qm9NzHqkCE+FUL5vwJboKzj8sBoCrwkIyWyFpRzDzFj04TraOT64XbGY2B2AFN5FOEP/e2XwxuEy8Yaj3HBekizRkXq3IXngmcjmBCb2YRtrfTj6qg+NmzAcb3IqYgzyaydxj/PseGgypsq5Aa3+YdaVXk7HdjUhpQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=aU1ZZnqgrNYkUx9VdxenAgpy84r4p+ScpIsiSUE6TbyJTCovzfqBwVI5rVuDuy4SBrvZzJQmULt/657Qw3YszYYnX0DKZqhAwRxMTUq3eP35TZipYI8NlcQrKpiL7X1HB32qTI66clH16a7cL+EpbO/E9upWCZe6aYdhi80YoO5/v0GJqxd7yRtpuLt0Paa7vBAyL64bVn08AenXHDxesC1cHg5ebfS5SeGuTb2R9Zm9XOCG356uB/AGuaxCG/OUeOQiCG7e8xfQUWpX9ed9/2JJyOdaZ5NPRxO0+tW+a6+sOPIpfQlgJ1SlOlpi1tpaFohE80MAsXBXO5USj6/+QA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TGf/my5sl8WwIsx2mk3hpmq8q5moudNVLV31EmcbJnE7C2bIw1Iiu7rega4yKj4YzUXzkZbGjSXouhbaxWUmGtJjfXF1NxCHiimrzxVVPhXGNRqTl/6fmjfjMJdlWTWFgyUOYBfEzmVA9mn30PU/IDLG+f6W4vrRRu+rgJbYbWpLJhwx0qjOjjCJPPz/0eT9CnbA6LHvOOaBjsLSkahEi9VNZRt7yJP9mXA0C1IS57n9ehlHXr2mPEZPIIqBSvHk6heZzM4RZknAq8+dCp3GKVqTswVUdcnPtFZDb1QRzq6cKLbGhfkWu+Og6DH2xaGhkTaYFqmuwQji13VAv7HNOw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: nd <nd@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 19 May 2022 02:37:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYZNkPIMguWCkDT0iF46SXZxuwPq0krieAgADat1A=
- Thread-topic: [PATCH v3 9/9] xen/x86: use INFO level for node's without memory log message
Hi Jan,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 2022年5月18日 21:34
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: nd <nd@xxxxxxx>; Andrew Cooper <andrew.cooper3@xxxxxxxxxx>; Roger Pau
> Monné <roger.pau@xxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3 9/9] xen/x86: use INFO level for node's without
> memory log message
>
> On 11.05.2022 03:46, Wei Chen wrote:
> > In previous code, Xen was using KERN_WARNING for log message
> > when Xen found a node without memory. Xen will print this
> > warning message, and said that this may be an BIOS Bug or
> > mis-configured hardware. But actually, this warning is bogus,
> > because in an NUMA setting, nodes can only have processors,
> > and with 0 bytes memory. So it is unreasonable to warn about
> > BIOS or hardware corruption based on the detection of node
> > with 0 bytes memory.
> >
> > So in this patch, we remove the warning messages, but just
> > keep an info message to info users that there is one or more
> > nodes with 0 bytes memory in the system.
> >
> > Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> preferably with ...
>
> > --- a/xen/arch/x86/srat.c
> > +++ b/xen/arch/x86/srat.c
> > @@ -549,8 +549,7 @@ int __init acpi_scan_nodes(paddr_t start, paddr_t
> end)
> > uint64_t size = nodes[i].end - nodes[i].start;
> >
> > if ( size == 0 )
> > - printk(KERN_WARNING "SRAT: Node %u has no memory. "
> > - "BIOS Bug or mis-configured hardware?\n", i);
> > + printk(KERN_INFO "SRAT: Node %u has no memory.\n", i);
>
> ... the full stop also dropped (and maybe the upper-case N converted to
> lower-case).
>
Ok, I will do it in next version.
> Jan
|
