[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/5] x86/perf: expose LBR format in PERF_CAPABILITIES
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Fri, 20 May 2022 14:58:01 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bwX4mSYgR9u+NMfq7GY0/SZf2/CRLgGzbn3igJFoc2w=; b=UZiioI0PQ8qxM3MNI/eFMThzf3s9nVeCatbpJD3aOxJpyz/X0mBgRP/apl+3otbPEeS6ZXSOuxqAXJZjeE3rL/YELZV9oZGjD/Flci8K6dhrvDuR3uylxDiacDq7Iyr4mSYGli6h2FAWkqPRJUEnJCj46k3SyjycC6A/IZLqcXciha0K6Pgqb29kwmaJGYhu1r17Zm7/+JTMvfdHI+5jCt/mhhbw0JBe1HtXpD/3wcgfozWd9ahUyMi86j0fdXJWxEBXTJnGO+s4SfdJdIulY+oB26UfIevY8BD16Dh7oSswgEaeV0vvIGO8a/vV8C5MTriL85B0hdFjvFcJhCTT5A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gCx8aMUPPU8Rh0eXi62dVitGRVANiJUxqhKM5fnGuuGwOwwCqqP2Ka1Yt6vV2EUjGNdUR+FBWXmz1IJC43JXpTJfhhdt0SWmva4J1kJM+qNuIi18FH4sLPju7XonEbpKIYyNKwQVuiAfasfaAEgnaXZBh/y382+D63GgHJLUVMWin1l2LZb5b0s++RyU5dBwRsojoWWqQnc3M1RnY3loobbuK75JjO5X6GqcQy76Y4mS7WN7Kx5UQFmC/4Gkby6Nz12o3+LSE2w9JHCuxqBHNFL8GiyVkqye/dfpEvr4ZoinSIOlQdUQO90C136ipWb8pMojNUpm/QTd/58kBwLBYA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 20 May 2022 14:58:13 +0000
- Ironport-data: A9a23:skpnhaKiAxVSki+vFE+RopQlxSXFcZb7ZxGr2PjKsXjdYENS1z0Fy 2AcWWGDP/7YZ2fwetwjbYTk9B4H7JDRmNJnGQRlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA149IMsdoUg7wbRh39Qw2YHR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 OkTsZqdTRYUB6nRpsUzekJEHjFCYKITrdcrIVDn2SCS52vvViK1ht9IXAQxN4Be/ftrC2ZT8 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHMCFGvuajTNb9G5YasRmNPDSf ccGLxFoawzNeUZnMVYLEpMu2uyvgxETdhUH8QvK/fFuvQA/yiQh+4DUCNDnWueDXN5yrEiUv j7j4XXAV0Ry2Nu3jGDtHmiXru3FkD7/WYkSPKal7fMsi1qWrkQMDDUGWF39puO24mauVtQaJ 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4LgEhwASEy66R6QDJAGEBF2dFcIZ/6p9wQiE23 FiUmd+vHSZorLCeVXOa8PGTsC+2Pi8Wa2QFYEfoUDc43jUqm6lr5jqnczqpOPTdYgHdcd0o/ w23kQ==
- Ironport-hdrordr: A9a23:Vj5RpKyn+V3+GAz8Qq3LKrPxdegkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMUs1MSZLXPbUQyTXc5fBOrZsnDd8kjFmtK1up 0QFJSWZOeQMbE+t7eD3ODaKadv/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZfbxp/hZMZtU TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESutu/oXvUiZ1SxhkFwnAid0idsrD AKmWZnAy1H0QKVQohym2q15+Cv6kd315ao8y7kvZKqm72EeNt9MbsBuWsRSGqm16Jr1usMr5 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvGbf2RYUh27D3xnklWavo3RiKmrwPAa 1rFoXR9fxWeVSVYzTQuXRu2sWlWjA2Eg2dSkYPt8SJ23wO9UoJhXcw1YgahDMN5Zg9Q55L66 DNNblpjqhHSosTYbhmDOkMTMOrAijGQA7KMmiVPVP7fZt3cE7lutry+vE49euqcJsHwN87n4 nASkpRsSood0fnGaS1rep2G9D2MRGAtBjWu7FjDsJCy8zBrZLQQF6+YUFrlde8qPMCBcCeU+ qvOfttcoreEVc=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYbE7auBjYBybQdEGztrNyxSKPiK0nzhyAgAACdoCAAArQgA==
- Thread-topic: [PATCH 3/5] x86/perf: expose LBR format in PERF_CAPABILITIES
On 20/05/2022 15:19, Jan Beulich wrote:
> On 20.05.2022 16:10, Andrew Cooper wrote:
>> On 20/05/2022 14:37, Roger Pau Monne wrote:
>>> --- a/xen/include/public/arch-x86/cpufeatureset.h
>>> +++ b/xen/include/public/arch-x86/cpufeatureset.h
>>> @@ -135,7 +135,7 @@ XEN_CPUFEATURE(SSSE3, 1*32+ 9) /*A
>>> Supplemental Streaming SIMD Extensio
>>> XEN_CPUFEATURE(FMA, 1*32+12) /*A Fused Multiply Add */
>>> XEN_CPUFEATURE(CX16, 1*32+13) /*A CMPXCHG16B */
>>> XEN_CPUFEATURE(XTPR, 1*32+14) /* Send Task Priority Messages */
>>> -XEN_CPUFEATURE(PDCM, 1*32+15) /* Perf/Debug Capability MSR */
>>> +XEN_CPUFEATURE(PDCM, 1*32+15) /*S Perf/Debug Capability MSR */
>> This is the bit which requires more toolstack logic to safely enable.
>> Using 's' for off-by-default is fine if we want to get the series in now.
>>
>> But before we expose the MSR generally, we need to:
>>
>> 1) Put the configuration in msr_policy so the toolstack can reason about it
>> 2) Reject migration attempts to destinations where the LBR format changes
> Since this could be quite restrictive, and since people needing to know
> they need to hide this feature for migration to work, I guess this would
> further want qualifying by "did the guest actually use LBRs so far"?
In practice, it's every major generation ("tock" on Intel's old model),
so isn't actually limiting the kinds of heterogeneous setups used in
production. (Migration gets steadily less stable the further apart the
two CPUs are.)
As to dynamic, no - that would be a security bug in a cloud scenario,
because there must not be anything the guest can do to interfere with
the manageability.
Use of LBR is rare, as demonstrated by the fact that noone has
complained about the fact that migrating such a VM will malfunction.
As we now have a way of reporting "no model-specific LBR", I'm tempted
to suggest that VMs get no LBR by default, and someone wanting LBR has
to opt in, which is also an explicit agreement to the migration limitation.
~Andrew
|
