[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/8] xen: reuse x86 EFI stub functions for Arm
- To: Wei Chen <wei.chen@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 23 May 2022 09:10:36 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HaxAR7rp3D5IiDtV0NxL4k3Xi5SJG6mTeMnH9eEUfD0=; b=fmPR3waYxv30pnSdBBecJCl/Slsww5XIl26mk7TYbwfX7DCqNCTg+S1aE6Jl2+Co1dQb44UCCJlK7OUOea88X/m40t57jaYGHbW8UfjUVMa5SNXfawsLG1rcd3kSzL+feSSS0RUEkA6A3YmyocLd9EyN5sCm1MMUCNA45vC+HyIBD6W/lK8Jb8TBDPlu1rJGhs6SowEsqB++HrN53tvmBsQMaHvIfkYnzMBic6tdEBDB3DKdqRUsjbHjpUjFb9zpPHUwQ0L92NO05rHF2eTdJDrC7JOqME8mt0ijuf5wwbgBtNg9MN1nDbKfxhBM1yv3TmO1Gzv6ltO2y84K/AMtiA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O5I0ERoU6oVsWAS4Mvk4oGSUwFNcQgMjfi32inZKOTijyLTpgOQEtWTr3Nw0Pd+HZPilojbKudvq+V4xoYLzMF+YHHRlNiAW3Mr2sIRnMyFweTdyuwnv7YhhYwwXarklEqrIJ8gtqI2N7InJK6fzsJkDUOjAMek2jegHAPUYtzK6kJp00p5F9uvKBY3wOCjoQ+zbeYBbPmec1Lwcrz6cIOcYCq4fzksZHkCxO5z6PT62ebOO6GkXfb7l5lyDs18igXD1mp3DdOLs2J2j+UBZ4Zp4k7zR8YOb1J7JC3hGc60ZgXrq8afoohBocnXl9VW5+4RODGn2Oi4mNBeNU/KMeg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: nd@xxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jiamei Xie <jiamei.xie@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 23 May 2022 07:10:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23.05.2022 08:25, Wei Chen wrote:
> x86 is using compiler feature testing to decide EFI build
> enable or not. When EFI build is disabled, x86 will use an
> efi/stub.c file to replace efi/runtime.c for build objects.
> Following this idea, we introduce a stub file for Arm, but
> use CONFIG_ARM_EFI to decide EFI build enable or not.
>
> And the most functions in x86 EFI stub.c can be reused for
> other architectures, like Arm. So we move them to common
> and keep the x86 specific function in x86/efi/stub.c.
>
> To avoid the symbol link conflict error when linking common
> stub files to x86/efi. We add a regular file check in efi
> stub files' link script. Depends on this check we can bypass
> the link behaviors for existed stub files in x86/efi.
>
> As there is no Arm specific EFI stub function for Arm in
> current stage, Arm still can use the existed symbol link
> method for EFI stub files.
>
> Change-Id: Idf19db1ada609d05fc0c0c3b0e1e8687c9d6ac71
> Issue-Id: SCM-2240
I don't think these two lines belong in an upstream submission (I
checked patch 2 and at least there they are two similar lines).
> Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> Tested-by: Jiamei Xie <jiamei.xie@xxxxxxx>
While I'm not really happy with the Arm side, it's only the other
parts which this is applicable to anyway (with the stray tags
dropped):
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
