[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH v4 1/8] xen: reuse x86 EFI stub functions for Arm


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Wei Chen <Wei.Chen@xxxxxxx>
  • Date: Mon, 23 May 2022 07:19:22 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tjP7EIVAkBtTHUF8RX62iJa4V70bhXyRSs0SPfDbKE8=; b=eiuifb7wLuJjmkwNbLBJySShAo9M+U9gfpXfHgQ+b4H6/DiGwm5VcmDE75kuVYakgZBXMKMzN5tD0/YIT8Bp8bSD4L+7V6VBUVE9fJd8IWUVGKEBz++35XLe1UpKZLdxX7f6JKDbZXVuxaTZab5XOCMc2KzIoiFqU6ho2dHImxHvHeYoACt0N3vyJPcWaFiVjNvLIgVy4DrfJgb6erbQpPvbau98Nbno8MLMoSwuGBHYN9Ym70aFanCav5q106U4NDKVG6Vdnc8H2Z1GYxndbVz3ZWt3EZoHJgyyvP1JDbAyrM326tnkA7ZS4Z3lnPzgYUv8GzPND1RG3jWu/5/rCg==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tjP7EIVAkBtTHUF8RX62iJa4V70bhXyRSs0SPfDbKE8=; b=KY+3QggHvrvGOlMi/hQxVg3GQQxLtgIvQ8/nt+tDluAZe1LWgQ2HmuDvKST0Jv5X9ZVM1X+zStGVSc24yMUOchWcoQfp9ylIA2BSeW7HKTL9ruZLBEv0DH0gTbb9WCNqq1gPvJxz62+01FwjN5/dS1QynnLEzJLX2f9/TeRDI8wDgLWrRrAB3L51voOh9UBZKQ/yZ9eChPzH2TDQCNtmJ5thmD38llXqM5VFFhpUf7ILBFbDODBSbZFehJObsLA7EdZjDjTITfu3OG4RoqAPIWBOjA02CDG8+RDz12Ihokl1Sjw+2lrb8h2Z5/I//0qN0u3Ol6/a9E7Vg+bCm1rUZA==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=WLDOOew1wHYqr98/tzkE2OJ+jpShoAm+sY4PVGqJaVqgVnUnajqNak4WT3HtrO+eKAUY5ITbx+ClPs3H1CuAezIfsM3CRg3kmNW1WsHaa7i3OcTqJmpw9JUUBfqfg6LwA0rJniEAxtCYPeEKFzsDuSmly5hifnYwfmNTV1javr0EB16rlypBNmHtSnW9ezNj24hfJYZEBq9AhSc7MTWvK7ujSzD8mpeN1ErDgl6IMFhCy3UPsbhKwCGEX/xkKm6wc4ZRGGiW5fjUNHuGY48BF15oQV3E0nlPofHMCbY52RrWPGEgdsFQFhxaI3bg/RnbC/DhotdNELkpD3/3SgXU1w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hiArrzuzXUe6l7zjYZLDfmUVseLhW0oZ8a270n+CMRG7zT/dcxR6/hOCkralwTJfH8ukb2LJInYHH84OOCCUmpMfEh1YBjxU7AyDC6hhhCKbFpTm3Tb9dHBXdf7vq3yRN866ASPbQm5dt9ozat+n0ATtMblsitpaX1Mg877imKu1It2Gao0vwBDiEYmRYgQiGvHdAWk+JG+BRgHB5yqwqYohteavaTYb4uV8dRCOoyy5OMvqDr7ofVEZ8Mny/l38cknMU2z29Jm4EkYu2FSp9TMfZNMJUVrrzO3n+1v2uwGPxtr8wjfi/MK1IFM4MEpa0DyhOCT3a3esSFr7iqN8pg==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: nd <nd@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jiamei Xie <Jiamei.Xie@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 23 May 2022 07:19:40 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHYbm35zG4dPV1xEEaM1LzUwkDv8K0sC4oAgAABzdA=
  • Thread-topic: [PATCH v4 1/8] xen: reuse x86 EFI stub functions for Arm

Hi Jan,

> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 2022年5月23日 15:11
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: nd <nd@xxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>; Julien
> Grall <julien@xxxxxxx>; Bertrand Marquis <Bertrand.Marquis@xxxxxxx>;
> Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>; Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx>; Roger Pau Monné <roger.pau@xxxxxxxxxx>; Wei
> Liu <wl@xxxxxxx>; Jiamei Xie <Jiamei.Xie@xxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v4 1/8] xen: reuse x86 EFI stub functions for Arm
> 
> On 23.05.2022 08:25, Wei Chen wrote:
> > x86 is using compiler feature testing to decide EFI build
> > enable or not. When EFI build is disabled, x86 will use an
> > efi/stub.c file to replace efi/runtime.c for build objects.
> > Following this idea, we introduce a stub file for Arm, but
> > use CONFIG_ARM_EFI to decide EFI build enable or not.
> >
> > And the most functions in x86 EFI stub.c can be reused for
> > other architectures, like Arm. So we move them to common
> > and keep the x86 specific function in x86/efi/stub.c.
> >
> > To avoid the symbol link conflict error when linking common
> > stub files to x86/efi. We add a regular file check in efi
> > stub files' link script. Depends on this check we can bypass
> > the link behaviors for existed stub files in x86/efi.
> >
> > As there is no Arm specific EFI stub function for Arm in
> > current stage, Arm still can use the existed symbol link
> > method for EFI stub files.
> >
> > Change-Id: Idf19db1ada609d05fc0c0c3b0e1e8687c9d6ac71
> > Issue-Id: SCM-2240
> 
> I don't think these two lines belong in an upstream submission (I
> checked patch 2 and at least there they are two similar lines).
> 

Ah, sorry, I had selected the wrong directory after I ran the scripts.
But the patch content is the same.

> > Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> > Tested-by: Jiamei Xie <jiamei.xie@xxxxxxx>
> 
> While I'm not really happy with the Arm side, it's only the other
> parts which this is applicable to anyway (with the stray tags
> dropped):
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> 

Thanks!

> Jan


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.