[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] tools/libs/ctrl: rename and export do_memory_op as xc_memory_op


  • To: Tamas K Lengyel <tamas.lengyel@xxxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Tue, 31 May 2022 14:43:04 +0100
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Tue, 31 May 2022 13:43:23 +0000
  • Ironport-data: A9a23:EGfTBq9JwVVsejvbQnJ1DrUD9H6TJUtcMsCJ2f8bNWPcYEJGY0x3y WoXWmjUbKrcZmegfdAkaN7jpkIH75OBmNJlTgo/+SE8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw3IPgW1nlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnby2SRwIIIPjovkcczNHPB1MF797wIaSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFIoZpnFnyyCfFfs8SIrPa67L+cVZzHE7gcUm8fP2O JBEMGs1N0SojxtnIU0uU8s4xsWUhUKjcXp8rliMrpcS/D2GpOB2+Oe0a4eEEjCQfu1Kmm6Iq 2SA+H72ajkYO8aY0iGt6W+3i6nEmiaTcJ4bEbSjsPpnhlKCy2g7CRsKWF/9qv684mauVtQaJ 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4LgEhwFjTkOyOuV/fXzVaCG4aADA7iCMobRws1 kSogf3GPyFukJeKZk6v3KWplQrnbED5MlQ+iT84oRotuoe++99q00+RHr6PA4bu0ISrRGiYL ySi6XFn2u5N1ZNjO7CTpwivvt66mnTeoufZDC3zV3nt0A52bZXNi2eAuQmCtqYowGp0ozC8U Jk4dyu2trlm4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvmwldRw0bJhaIme4C KM2he+2zMYIVEZGkIctO97hYyjU5fSI+SvZugD8MYMVP8kZmP6v9yByf0+At10BY2B1+ZzTz ayzKJ72ZV5DUPwP5GPvG481jO5wrghjlDy7eHwO50n+uVZoTCXNGelt3ZrnRr1R0Z5oVy2Mq 4sFapLRkUgDOAA8CwGOmbMuwZkxBSBTLfjLRwZ/LIZv/iIO9LkdNsLs
  • Ironport-hdrordr: A9a23:pQyRfaFy1Ke9AWAfpLqF5pLXdLJyesId70hD6qkoc20tTiSZ// rOoB1p726NtN9xYgB/pTnuAtjkfZqxz/FICMwqTNGftWrdyTqVxeNZnO/fKlTbckWUnIMw6U 4jSdkYNDSaNzhHZLPBkWuF+qEbsbq6Gc6T69s2hE0dNj2CI5sQlTuQ9mygYwZLrPYtP+twKH JjjPA37gZIME5nE/hSfRE+LqL+jsyOm5T8bREcARk7rAGIkDOz8bb/VwOVxxEETlp0sMMfGE X+4n7ED5+YwoSGI97nph7uxoUTnMGkxspIBcSKhMRQIjLwihywbIAkX7GZpjg6rOym9V5vyb D30mEdFtU272mUcnC+oBPr1QWl2DEy62X6wVvdhXf4u8T2SD8zFsIEj4NEdRnS7VYmobhHod V29nPcs4ASAQLLnSz76dSNXxZ2llCsqX5niuIXh2w3a/psVJZB6YgEuE9FGpYJGyz3rIo9Fv N1Ec3a7PFKNVuHcnHQpABUsZGRd2V2Gg3DTlkJu8ST3TQTlmt+1VEEyMsWmWpF/I4hSoND+/ /PPs1T5f1zpoZ/V9M9OA92KfHHSlAkb3n3QSGvyRWOLtBJB5q7w6SHroncxIqRCd41JVsJ6e T8uCAxjx92R6vDM7zw4HQQyGGwfIyUZ0WS9ildj6IJ/oHUVf7xNzGfRBQgiM2l5/UFBMrDXe 2vUagmXMMKdwbVaMF0Ny6SYegVFZFfPfdl4urSFT+105n2wsOBjJ2GTB5gSYCdSAoMSyfjBn MYUHzpKN9d613DYA6jvDHBH27oclbyuY19C7Lb+e978vlRCrFx
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Thu, May 19, 2022 at 01:16:35PM -0400, Tamas K Lengyel wrote:
> Make the do_memory_op function accessible to tools linking with libxc.
> Similar functions are already available for both domctl and sysctl. As part
> of this patch we also change the input 'cmd' to be unsigned int to accurately
> reflect what the hypervisor expects.
> 
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@xxxxxxxxx>

Is exposing do_memory_op necessary? This kind of looks like a revert of
35e135f116 ("libxc: make xc_memory_op library private"). Anyway, if
there isn't a better alternative: Acked-by: Anthony PERARD 
<anthony.perard@xxxxxxxxxx>

Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.