Re: [PATCH v2] tools/libs/ctrl: rename and export do_memory_op as xc_memory_op

[Tamas K Lengyel <tamas.k.lengyel@xxxxxxxxx>]

On Tue, May 31, 2022 at 9:43 AM Anthony PERARD
<anthony.perard@xxxxxxxxxx> wrote:
>
> On Thu, May 19, 2022 at 01:16:35PM -0400, Tamas K Lengyel wrote:
> > Make the do_memory_op function accessible to tools linking with libxc.
> > Similar functions are already available for both domctl and sysctl. As part
> > of this patch we also change the input 'cmd' to be unsigned int to 
> > accurately
> > reflect what the hypervisor expects.
> >
> > Signed-off-by: Tamas K Lengyel <tamas.lengyel@xxxxxxxxx>
>
> Is exposing do_memory_op necessary? This kind of looks like a revert of
> 35e135f116 ("libxc: make xc_memory_op library private"). Anyway, if
> there isn't a better alternative: Acked-by: Anthony PERARD 
> <anthony.perard@xxxxxxxxxx>

Thanks! For compatibility reasons it's easier for tools supporting
multiple versions of Xen to have direct access to xc_memory_op instead
of having to look up different versions of libxc functions and cast
them via dlsym based on the Xen version detected. It also makes it
possible to access memory_op hypercalls for which there are no libxc
wrappers.

Tamas