[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 1/4] build: xen/include: use if_changed
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Mon, 6 Jun 2022 14:39:18 +0100
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 06 Jun 2022 13:39:31 +0000
- Ironport-data: A9a23:XJVZE6NcNkIM8m7vrR3dl8FynXyQoLVcMsEvi/4bfWQNrUor1jIBn TNKUG6COPyCajf3fY9zaorlp0tXvZPWzIVjTQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZn2tMw27BVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z7 o4UhMOMF1gVZvOSuOs7bR92NnheIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gRR6yPO 5dBMVKDajzHURAQPEUOE6hnwr/rr1rnURdy9nWa8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv G2u13T0BFQWOcKSzRKB82mwnanfkCXjQoUQGbaksPlwjzW73XcPARcbUV+6p/iRiUOkXd9bb UsO9UIGr6I/6UiqRdnVRACjrTiPuRt0c9hNF+w37imdx6yS5ByWblXoVRYYNoZg7pVvA2V3i BnZxLsFGACDrpWzEiusqYvK8g/qZ3Y1Ikk8YwEhFCsatoyLTJ4Isv7fcjpyOPfr04GvQ2msm W/iQDsW3OtK05NSv0mv1RWe2m/3+MCUJuIgzl+PNl9J+D+Vc2JMi2aAzVHApchNI4+CJrVql ChVwpPOhAzi4HzkqcBsfAnuNOvwjxp9GGeA6WOD5rF4n9hXx1atfJpL/BZ1L1pzP8APdFfBO RGO5V8MuMcLYSXyPcebhr5d7OxzlMDd+SnNDKiIPrKinLAtHON4wM2eTRHJhD28+KTduao+J Y2aYa6RMJruMow+lGDeb75EidcDn3lirUuOFMuT50n2jtKjiIu9FO5t3K2mNbhpsstpYWz9r r5iCid940wGALGuPHSMqN57wJJjBSFTOK0aYvd/LoarSjeK0kl4YxMN6dvNo7BYopk=
- Ironport-hdrordr: A9a23:k0sQe6HMYMcmCCwCpLqFfZHXdLJyesId70hD6qkvc3Bom52j+v xGws5w6fatskdoZJhSo6H6BEDgewKVyXcb2/h0AV7PZmjbUS6TXfhfBOjZsnbd8k/Fh4lgPM 5bGsAUZ7PN5BpB/KDHCWKDYrUdKay8gcWVbJDlvhVQpG9RC51I3kNcMEK2A0d2TA5JCd4SD5 yH/PdKoDKmZDA+ctm7LmNtZZmPm/T70LbdJTIWDR8u7weDyRmy7qThLhSe1hACFxtS3LYZ93 TfmQCR3NTujxj78G6S64bg1eUWpDLT8KoCOCVKsLlXFtzYsHfnWG2mYczBgNl6mpDr1L9gqq i3n/5pBbUP15qWRBD+nfKl4Xid7B8+r3Dl0lOWmn3lvIjwQy87EdNIgcZDfgLe8FdIhqAK7E tn5RPti3NsN2K1oM093am5azh60k6v5XYym+8aiHJSFYMYdb9KtIQauEdYCo0JEi724J0uVL AGNrCU2N9GNVeBK3zJtGhmx9KhGnw1AxedW0AH/siYySJfknx1x1YRgMYfgnAD/pQgTIQs3Z WzDo140LVVCsMGZ6N0A+kMBcOxF2zWWBrJdHmfJFz2fZt3SU4la6SHk4ndyNvaBqDglqFC56 gpeGkoxFIPRw==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Jun 02, 2022 at 11:11:15AM +0200, Jan Beulich wrote:
> On 01.06.2022 18:59, Anthony PERARD wrote:
> > Use "define" for the headers*_chk commands as otherwise the "#"
> > is interpreted as a comment and make can't find the end of
> > $(foreach,).
>
> In cmd_xlat_lst you use $(pound) - any reason this doesn't work in
> these rules? Note that I don't mind the use of "define", just that I'm
> puzzled by the justification.
I think I just forgot about $(pound) when I tried to debug why the
command didn't work in some environment (that is when not using define).
I think the second thing that make me not replacing '#' by "$(pound)" is
that reading "#include" in the Makefile is probably better that
reading "$(pound)include".
I guess we should add something to the justification like:
That allow us to keep writing "#include" in the Makefile without
having to replace that by "$(pound)include" which would be a bit
less obvious about the command line purpose.
Thanks,
--
Anthony PERARD
|
