[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 1/4] build: xen/include: use if_changed
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 7 Jun 2022 08:26:21 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s0LUxGRu6M1umnyDasRxv1iWXBTB8HSglNSzzceqsfo=; b=ee2mHRRsywWnepscHCzhyy63nFk3CyHICt/eE/7eupW5wgeAdkMUsnoItEsMqpehZzaQecIxroQFJquPBP5VvMxC8LJotRlF7zVUcsPoHLrNTQOW2dQT/T2qpuvt2XpRw0SY3BImuXLQatGQDksPqUcQv6CYgitVTMAgPE/OJ6I3uMFv2PMe8f6ddgRH2IGizQSBp5fP6FnhixkWbHR8lFMR5yxft0UUQAMuF6cM4NNG/vveYtWD9hNWzj/EvxHmPxtz7cvGcXqivc3GAEQ3aztJK/so2KpbWlhhH1rzUq7wGJp6umzc0CPE+fKXPfK3cNnyYCVGFMJpxjW8+mTfsQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WyK0B+5QqUog+2L+1APVs5BvfY5trp7dxupV6OaX+s1EYXpBI2lUtOZ5VDas7Z3Jf8RrIahaxHBP3qducb955LqRIdPnUa6U853T1Pr4z7TA91kMTj/RIdiHJZz4OQ23kwroCtzoEXB1hnrUQLj45oDJ2HBhy3TAvFWaCb6XGR98IElPoY7fKvkJoXyRoFJXsfxwpmI8KMTdn/MoogKfviOr77AiDQXT14q/XdX7Ol10auW359Lyk88Qc2uBiHA3yJETxvan10XJOERG1u95021Tx5UH6Xk7/dD4TefxaDBBMNTAsuTexceEJKQJLDYdZLOL8SS4PVu6L26fMWKDbA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 07 Jun 2022 06:26:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.06.2022 15:39, Anthony PERARD wrote:
> On Thu, Jun 02, 2022 at 11:11:15AM +0200, Jan Beulich wrote:
>> On 01.06.2022 18:59, Anthony PERARD wrote:
>>> Use "define" for the headers*_chk commands as otherwise the "#"
>>> is interpreted as a comment and make can't find the end of
>>> $(foreach,).
>>
>> In cmd_xlat_lst you use $(pound) - any reason this doesn't work in
>> these rules? Note that I don't mind the use of "define", just that I'm
>> puzzled by the justification.
>
> I think I just forgot about $(pound) when I tried to debug why the
> command didn't work in some environment (that is when not using define).
>
> I think the second thing that make me not replacing '#' by "$(pound)" is
> that reading "#include" in the Makefile is probably better that
> reading "$(pound)include".
>
> I guess we should add something to the justification like:
> That allow us to keep writing "#include" in the Makefile without
> having to replace that by "$(pound)include" which would be a bit
> less obvious about the command line purpose.
I'd be okay with this, and I'd also be okay with adding this while
committing. With it added
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
