[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] add more MISRA C rules to docs/misra/rules.rst
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 10 Jun 2022 12:23:09 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+HsS90DI+RX+hBh9tqd3dEkYH5Jd/Gq7vTcCXRSzz/c=; b=f7VziVLi8roURD9+W0e0YTZFfQ8H9KDAPB1v9S1lKU3oVZfAbubVvubfB1OQ/AJDAN/3/+fEdVq91soK89yAxkZh9AzQo7E3PAzY/KR1FyJcLW7oAx164wl1ByZJ3zwxTCxkyu6un1QhgUBagApljHTEseIqsaJuc5jRH8zq6u2QRtt/dXNfMzg8dNEkuQEjGh+Aejh9B9Hy4krzhhZHchePtpS1kGxxlVeQSdmQPEoL231Y5EfUMF8AacxfMERGUZpFl7Rr+nnqUj/3dfLHRPzQAGkknXX0Uyp2tmoqdH0O7tnBMyL+pZ1nSjeYiy0rv6aIGSZnaPdIynzZSrdpxg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L+//Bycmsicfi7hiUMe4gw9oORTQfoLBRIK3REaemV/2om+nWvQHFxHUmeLyuWhU2gLkoF6okmdbLuT4jusL8YjQzDc5/AqKwlUSRvAbz3h/NNQsXAUbypQLdirWrs2ZkB9J9oHXCmR5jJ5nntEZu+rQMj9rZLKbpLcFMqbzrxQF21WzbR1pcvjhipeIpUmfwhP5YylvLx/JFu5H0+xbml/ndI9136v1BysukTrGL1gUJt1Hp1w4G2NaiK3P76QXD7eKJoN4FlRl6hq7gvbop7JbEDtGM9lhPWMdxiQJSDiMNeWPo0Y/VYg5VupRqwmTfv7RxTgXrqGrjnkmOpB82w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: George.Dunlap@xxxxxxxxxx, roger.pau@xxxxxxxxxx, Artem_Mygaiev@xxxxxxxx, Andrew.Cooper3@xxxxxxxxxx, julien@xxxxxxx, Bertrand.Marquis@xxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 10 Jun 2022 10:23:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10.06.2022 02:48, Stefano Stabellini wrote:
> + * - `Rule 5.3
> <https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_05_03.c>`_
> + - Required
> + - An identifier declared in an inner scope shall not hide an
> + identifier declared in an outer scope
> + - Using macros as macro parameters at invocation time is allowed,
> + e.g. MAX(var0, MIN(var1, var2))
I think the connection between the example and the rule could be made more
clear, e.g. by adding "... even if both macros use identically named local
variables".
> + * - `Rule 14.1
> <https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_14_01.c>`_
> + - Required
> + - A loop counter shall not have essentially floating type
This looks to be missing "point"?
Jan
|