Re: [PATCH] add more MISRA C rules to docs/misra/rules.rst

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Fri, 10 Jun 2022, Jan Beulich wrote:
> On 10.06.2022 02:48, Stefano Stabellini wrote:
> > +   * - `Rule 5.3 
> > <https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_05_03.c>`_
> > +     - Required
> > +     - An identifier declared in an inner scope shall not hide an
> > +       identifier declared in an outer scope
> > +     - Using macros as macro parameters at invocation time is allowed,
> > +       e.g. MAX(var0, MIN(var1, var2))
> 
> I think the connection between the example and the rule could be made more
> clear, e.g. by adding "... even if both macros use identically named local
> variables".

Yep, I'll add


> > +   * - `Rule 14.1 
> > <https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_14_01.c>`_
> > +     - Required
> > +     - A loop counter shall not have essentially floating type
> 
> This looks to be missing "point"?

I am not sure what you mean. Do you mean "floating-point" instead of
"floating" ?

This is the actual headline for Rule 14.1. MISRA defines "Essential
types" (8.10.2), so in this case it is referring to the type
"essentially floating", which includes float, double and long double.

If you meant something different, I'll address it in the next version of
the patch.

Cheers,

Stefano