[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v5 2/5] grub-mkconfig linux_xen: Fix quadratic algorithm for sorting menu items
On Thu, Jun 9, 2022 at 2:50 PM Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx> wrote: > > The current implementation of the 20_linux_xen script implements its > menu items sorting in bash with a quadratic algorithm, calling "sed", > "sort", "head", and "grep" to compare versions between individual lines, > which is annoyingly slow for kernel developers who can easily end up > with 50-100 kernels in their boot partition. > > This fix is ported from the 10_linux script, which has a similar > quadratic code pattern. > > [ Note: this is untested. I would be grateful if anyone with a Xen > environment could test it before it is merged. ] Hi, Mathieu, I tested by manually applying patch 2/5 on top of Fedora 36's installed /etc/grub.d/20_linux_xen, and manually applying patch 1/5 to /usr/share/grub/grub-mkconfig_lib. It seems to generate grub.cfg menuentry-ies in the correct order. Note for patch 1/5, it's best practice to use "$@" with the double quotes to prevent word splitting of arguments. Doesn't really matter for that function at this time though. Regards, Jason
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |