[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2 3/4] build: set PERL
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 15 Jun 2022 08:11:10 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JbKF67I1vWo4HsrzBiw+pIQPkAMMnJYbfh2+y90TsLY=; b=KuH5VIQIZkzmbb2RymnTLE6yZf5UWOIJcPG0hiVWr3tzumham53UlJs8c8stTjgPbikodga1xF5E64P0FVMVgqh9Zff/BlTwlvE1EkBIfDnge9BGtuVW4wFs/Q9Y4Ts8z6UyLWE8pCxCCYEHnUyxFb3F7WU/ehEf9a2yBdCaK1k4HGmpPz5qyg8r/wgEoiE35+ECRWpH9zQkWrjpZg5yzUUQf1C4xHQOSPXbTNPHJ/4A6ff11VixsqE11Kjv2KER5C4Z7pvmOQcQ2oqqhDkKVeqY7gRl0YoVvtm15Nt2q2m3Ws15tClJgYQsu7BIuTRNP2HA2QxFWtJBS9Ztor6XQw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iUw83df3KQc7UNRR87SHdSNEy8X6YC7Mr3q3jilvsqwlZ4lT+W6X5QoCM98ks11/zY4o2rr8yJKln76+mdTjQlaSwtsQhM5+clcVFuXOtdn6dfZJK7D3EA+FeqQ/EtTjRoVEdOoFZ/23aN7WfLCWg5Q9U1K4/TLKbXke5gq9F2lvGNv28ZmIcN0ROgPJWQyiUfL0SG2K1ffxSo91cXULajyJI5WnXLjQykG2gMI8We+rApPboxmMK1PIvjRbsxt01hCvrvOsLrT7tWfqbM+XhWUsSXZDyCCKfhQd5emJYB9c58qp/B+ik/RLWjCuWeGRQnOoM5OFfFDjxzlIcamVjg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 15 Jun 2022 06:11:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.06.2022 18:22, Anthony PERARD wrote:
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -22,6 +22,7 @@ PYTHON_INTERPRETER := $(word 1,$(shell which python3
> python python2 2>/dev/null)
> export PYTHON ?= $(PYTHON_INTERPRETER)
>
> export CHECKPOLICY ?= checkpolicy
> +export PERL ?= perl
>
> $(if $(filter __%, $(MAKECMDGOALS)), \
> $(error targets prefixed with '__' are only for internal use))
Considering my patch yesterday that moved the exporting of CC etc, I
wonder if - at the very least for consistency - this and the neighbouring
pre-existing exports shouldn't all be moved below the inclusion of
./Config.mk as well. After all ./config might override any of those.
(Yes, the ones here don't prevent such overriding, but only as long as
there aren't any further make quirks.)
Since this may want doing in a separate patch, this one is
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
