[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2 3/4] build: set PERL
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Fri, 17 Jun 2022 15:59:04 +0100
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 17 Jun 2022 14:59:28 +0000
- Ironport-data: A9a23:9EU24qJ+rCYNfepwFE+R1ZUlxSXFcZb7ZxGr2PjKsXjdYENS0TIBy DMaXmuEb6zfYTH1KY1wat+1900P7JTTyNEyTAVlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA14+IMsdoUg7wbRh3Nc22YTR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 OtxlJ/oTjozBP3ztu8QSQliM3w5FqITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq 6ZecmpUKEne2aTmm9pXScE17ignBMDtIIMYvGAm1TzDBOwqaZvCX7/L9ZlT2zJYasVmQq2OO JBHMGcHgBLoakVyFAooKb0C27ms30fHYyF4rg+5nP9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo XjJl0zpDxdfONGBxD6t9nO3mvSJjS79QJgVFrCz6rhtmlL77ncIFBQcWF+/oP+4ok2zQdRSL woT4CVGhao4+VGvT9L9dwalu3PCtRkZM/JSDuk75Qel2qfSpQGDCQA5oiVpMYJ88pVsHHpzi wHPz4iB6SFTXKO9d0689e+TkCmIaRc7JmIYdRUkEEwu7Iy2yG0stS4jXuqPAYbs0ICoRWqom WjXxMQtr+5N1JBWjs1X6XiC2mvx/caRE2bZ8y2NBgqYAhVFiJlJjmBCwXzS9r5+IYmQVTFtV 1BUypHFvIji4Xxg/RFhodnh/5nzvp5pyBWG3TZS82AJrlxBAUKLc4FK+y1ZL0x0KMsCcjKBS BaN5F4NvMMPYSPzMPUfj2eN5yMCnMDd+SnNDKiIPrKinLAqHON4wM2eTRHJhD28+KTduao+J Y2aYa6RMJruMow+lGDeb75EidcDn3lirUuOFcGT50n2itK2OS/KIYrpxXPTN4jVGovf+16Lm zueXuPXoyhivBrWOHmIrdZPdAhQdxDWx/ne8qRqSwJKGSI+cElJNhMb6epJl1BN90iNqtr1w w==
- Ironport-hdrordr: A9a23:Y1Ekt61TqPGczkPIzqr3rwqjBEgkLtp133Aq2lEZdPU0SKGlfg 6V/MjztCWE7Ar5PUtLpTnuAsa9qB/nm6KdgrNhWItKPjOW21dARbsKheffKlXbcBEWndQtt5 uIHZIeNDXxZ2IK8PoT4mODYqodKA/sytHWuQ/cpU0dMz2Dc8tbnmBE4p7wKDwMeOFBb6BJcq a01458iBeLX28YVci/DmltZZm4mzWa/KiWGCLvHnQcmXGzsQ8=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Jun 15, 2022 at 08:11:10AM +0200, Jan Beulich wrote:
> On 14.06.2022 18:22, Anthony PERARD wrote:
> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -22,6 +22,7 @@ PYTHON_INTERPRETER := $(word 1,$(shell which
> > python3 python python2 2>/dev/null)
> > export PYTHON ?= $(PYTHON_INTERPRETER)
> >
> > export CHECKPOLICY ?= checkpolicy
> > +export PERL ?= perl
> >
> > $(if $(filter __%, $(MAKECMDGOALS)), \
> > $(error targets prefixed with '__' are only for internal use))
>
> Considering my patch yesterday that moved the exporting of CC etc, I
> wonder if - at the very least for consistency - this and the neighbouring
> pre-existing exports shouldn't all be moved below the inclusion of
> ./Config.mk as well. After all ./config might override any of those.
> (Yes, the ones here don't prevent such overriding, but only as long as
> there aren't any further make quirks.)
Sounds good, we can move CHECKPOLICY and PERL, but there's a problem
with PYTHON. Config.mk define a different value for PYTHON, so the one
in xen/Makefile needs to be set before including ./Config.mk.
Thanks,
--
Anthony PERARD
|
