[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] xen/lib: list-sort: Fix MISRA C 2012 Rule 8.4 violation


  • To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Wed, 22 Jun 2022 15:20:38 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5vFoZcwbqI+NsiNNqicTnfXAr7FgcW/4VWjVFJkbny4=; b=No+CCVQMhBlDFh/b2bAZyUWuyvgin31pF3Qdq5+cv6GOnoO55owGWR7eNKQgeE5WKwF6viJwdKchevfCpDDZg9bHb41i0Jwc9RUQZ66HZHgWqm0wBeQs3D/ARZx/y8z3HM7AfoWvPwPSI1kuy/TW/BzuPyQjl1qXdayGJCS9HzU6B3N0/GX5oAVe3J/gwAi0qCHD7wwU7JOQIlAMzHuUjynFocDSwtMrHmL36GRpXos7FXMBEe23sdPS4nd6MxVCxV/lXJeeLJjy/bDj4dcNtnfEtOhRpCWv5qtXiQyPxWCCDI5+hAX31sPyWeHchqre2C7nw7BHak6uTY9FfISxxw==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5vFoZcwbqI+NsiNNqicTnfXAr7FgcW/4VWjVFJkbny4=; b=M85nIfgdwaTZAhE4veDdRSWLZSzXDYnFk24y4ZDlV/ut/rR7LgJiaOCQGOQsTXdVbQJMDplhargc9cOhGwvZIHLQWqs2kgrR+TnxL0b3/9yrhPa8fVd9SKyj84Mvi3YEQ6v8Q2znAYhk1/CdZ/J4dpTZPFASCQCNd2TdLAHmQNWYBv1sAWBfHBnCi0aKlsAAufboXg9XVfN0IbuEQso0DS+m1H599uWlwfizNnmvPKTr54GU4szu/yUFiXnEws9k5UwoeWOWD3RVMvt958raXRuoz8FJS2lOtWINob1+NXAXu4680DhV8O8PKpfQEjH9lbVvt59UpJv/gMxSXVpUjQ==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=T1M0S/a5EkQ6O3NlMhHxRuUipc80cNfhk+6YopXS/Y4B8N0Jf47Y+XehCW0iZz2/vaaLtDtrH7z+FHcgaB8Y7IW4d9k05NeE8lkO5qY9jlMxCNVenF6fPXxcyk7s58gg04hVIpA/rxUd7Aoo17DIF9HUazxs3UAPA/KVc8EHA9x7vpUKUACgzydpJ/DRCAU/cAgQMUZwDAZtQxc/jrCtHvaatIBsq4nfDpjs7camHWLg489wWvDvyqae5ZUl0s6nBdMGzmHlSLLVVWYtPVq6ytHY8YEWESBRYFhDP/SxIKt0gshIiOzKDp/k87r9y/qnKhnkQ731uWfiuEyyM2L1Yg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U/wdRF+2A2bQloyCfDJpYY7NDBZSNhesKnQa75rmMTmlEVIkPNYrAJRXSrHiSdt8EET0jLXw4OIS9pMXqjKjvpXjeNI+CGMHATxa3Ie6ikS40g1T501As1lZDVNkkQmEXn8nP8VpLKNvqxR+EQ7It9T9wLqfjFYqa+L5mX7pYhlptawZEohV9ybBmtSnQb3mxHOPLbXoe8k8DgEJEAuzrb/WslFEkEXTnW8Qdgqf+NGg/X0cvNJ0ex8USYQixroapYxBSAToM0QjyS1xwMXRjCfAaKesOoYuM9Agm4Yc3JdqTC6p4EqtlYem74nx0wuNugRc03qHektTfOwn40PV2w==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Wed, 22 Jun 2022 15:20:56 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHYhksCTJ95E1G/9EC0Af/pOiohlq1biqoA
  • Thread-topic: [PATCH 2/3] xen/lib: list-sort: Fix MISRA C 2012 Rule 8.4 violation

Hi Xenia,

> On 22 Jun 2022, at 16:15, Xenia Ragiadakou <burzalodowa@xxxxxxxxx> wrote:
> 
> Include header <xen/list_sort.h> so that the declaration of the function
> list_sort(), which has external linkage, is visible before the function
> definition.
> 
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>

Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>

Cheers
Bertrand

> ---
> xen/lib/list-sort.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/xen/lib/list-sort.c b/xen/lib/list-sort.c
> index f8d8bbf281..de1af2ef8b 100644
> --- a/xen/lib/list-sort.c
> +++ b/xen/lib/list-sort.c
> @@ -16,6 +16,7 @@
>  */
> 
> #include <xen/list.h>
> +#include <xen/list_sort.h>
> 
> #define MAX_LIST_LENGTH_BITS 20
> 
> -- 
> 2.34.1
> 
> 




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.