[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] xen/common: gunzip: Fix MISRA C 2012 Rule 8.4 violation


  • To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Wed, 22 Jun 2022 15:21:36 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o6f/osCnMMDoF/xXxvUEBQIfwtEhSDGWQtqTReoF29Y=; b=daU6oVrGQr+91L12q54G7V4lNpfYOyNzYPiYQ/2l8PldPIfDo1tLjZ/rGCfcQ8WoIx0ebSw4IfXmeZo2KSyoFmFJ8eCGQZOSVa6L6fxPdzf80dFlidRlS9P1ivhHLmXvYzVILjO5zmo0mKI2npyZFnYSOSilhggmHC63YgSRTc/Cn1D66Bxf9IoGO/KDY40M4AwOvK1yGAyT9njDW/AetmZZ3a/4VWbCjMwQzvjNLQQguqQy3p5dqW9RvnhNrtznNsywASqhJVfp5zUqIAkO+2qcjoc+q5/e3nVu8GrusefGVS7g9m2k9rhnmi2y0tynsoN7UfS1NP/VZnq1IkNJ0A==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o6f/osCnMMDoF/xXxvUEBQIfwtEhSDGWQtqTReoF29Y=; b=eMAKpjkEKAn1jOhQ0npJUaMHNUO7Ac4kmX1PahUGH3jgOeNzsXAzvo4brQTXqX6h1z/fvYW5S7p/atuZ5PYlU+EOU5+Srz9aqEDTtvzNjEqBVPFNqUbp/dcQHHpb5Vev4jRZRo8VPgu1vx2OX23Sa89p5Q6z1+PSxANdgiHQd3NHhr73N8Nn5wojSa1IjbeG1rMJTPN1xQjd5ZJO0JuEjKwmleK67nYf3kkvSfFRNGNcJNdfrwdVqw7JhTl1bWifDHsy1ok3TnhltAT4oOyDf8FnxWhwqd/bxxcFtdNW21c5y+meTfG4dYLL6N3MWoKXwwC/6CH58PvC25Yki94qfw==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=GwYvtfwx8s1mS3OSFwFB/7hcHpOMsTwLHNFlgoboWVkUkvE7koXclo7kyAmmvou3HBQGY9bo1Oxn/BCmgZSaEnbAYu/YSkAKUhp50Wm9gejJ3His/eoMBSG8MZGxuJKcAUyPwOrcYTt/E7T9H2JNZAQtseEJ1X65osdhZr4dbOuHI+pjVlILqcZpQc6CBiaALSmT7sGrEMa+7hgOIIuCS3rZ/sfr3v8EcWn5TiPb7bwrmvUpDw3WYNDfKqL9Ur09eA+FCIy42UOw8htdypQ1caSZZZGHL3yeWGwmgUj48vBxGzY5NinaGJnZHdqRrLvfs/XKnWNVHBQUMxTUvcLV+g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cqpbFbnLwqm6VllR17JbHbq3CRKsDeepNlHmmw+e/vjaQY7dJFbXPgZMj+lI+8hokary/nOKpTv97qNnQirxKu9fSGGDRJO5wTEnGAdhxC6K42WJrqWY/2orziKi64Y8ec5KRbnjzG9E35JNuPoOMCfpfWaxTOxApRgcp9qTw6k8pZYxbS31Fh0vzAitOEZ0Mu9Hl7TiFi+uDSqnqa5qKFyT/A33NaWOppg00H2qPZ0FvKgzW18/2Y/TPb3wsWgpmdUPEXIjvKaFbUNxk4jkOl/thDo92pPkuBqu8d7b+WRMg9RmmlPMEYKb8pIMQCvrtEtp3DoDOWbNMt3h8cbiYw==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Wed, 22 Jun 2022 15:21:49 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHYhkr4CzBVsyJHpUKOeXKFemajka1bivAA
  • Thread-topic: [PATCH 3/3] xen/common: gunzip: Fix MISRA C 2012 Rule 8.4 violation

Hi Xenia,

> On 22 Jun 2022, at 16:15, Xenia Ragiadakou <burzalodowa@xxxxxxxxx> wrote:
> 
> Include header <xen/gunzip.h> so that the declarations of functions 
> gzip_check()
> and perform_gunzip(), which have external linkage, are visible before the
> function definitions.
> 
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>

Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>

Cheers
Bertrand


> ---
> xen/common/gunzip.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/xen/common/gunzip.c b/xen/common/gunzip.c
> index b9ecc17e44..aa16fec4bb 100644
> --- a/xen/common/gunzip.c
> +++ b/xen/common/gunzip.c
> @@ -1,4 +1,5 @@
> #include <xen/errno.h>
> +#include <xen/gunzip.h>
> #include <xen/init.h>
> #include <xen/lib.h>
> #include <xen/mm.h>
> -- 
> 2.34.1
> 
> 




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.