[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/arm: smpboot: Allocate the CPU sibling/core maps while preparing the CPU





On 15/06/2022 01:23, Stefano Stabellini wrote:
On Tue, 14 Jun 2022, Michal Orzel wrote:
On 14.06.2022 13:08, Julien Grall wrote:
+    unsigned int rc = 0;
... here you are setting rc to 0 even though it will be reassigned.
Furthermore, if rc is used only in case of CPU_UP_PREPARE, why not moving the 
definition there?

Because I forgot to replace "return NOTIFY_DONE;" with :

return !rc ? NOTIFY_DONE : notifier_from_errno(rc);
That is what I thought.
With these fixes you can add my Rb.

And also my

Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>

Thanks. I have committed this patch.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.