[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [PATCH] public/io: xs_wire: Allow Xenstore to report EPERM
From: Julien Grall <jgrall@xxxxxxxxxx> C Xenstored is using EPERM when the client is not allowed to change the owner (see GET_PERMS). However, the xenstore protocol doesn't describe EPERM so EINVAL will be sent to the client. When writing test, it would be useful to differentiate between EINVAL (e.g. parsing error) and EPERM (i.e. no permission). So extend xsd_errors[] to support return EPERM. Looking at previous time xsd_errors was extended (8b2c441a1b), it was considered to be safe to add a new error because at least Linux driver and libxenstore treat an unknown error code as EINVAL. This statement doesn't cover other possible OSes, however I am not aware of any breakage. Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx> --- xen/include/public/io/xs_wire.h | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/include/public/io/xs_wire.h b/xen/include/public/io/xs_wire.h index c1ec7c73e3b1..c23b63cdfeaf 100644 --- a/xen/include/public/io/xs_wire.h +++ b/xen/include/public/io/xs_wire.h @@ -76,6 +76,7 @@ static struct xsd_errors xsd_errors[] __attribute__((unused)) #endif = { + XSD_ERROR(EPERM), XSD_ERROR(EINVAL), XSD_ERROR(EACCES), XSD_ERROR(EEXIST), -- 2.32.0
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |